Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React without ES6 #95

Merged
merged 5 commits into from
Mar 3, 2019
Merged

React without ES6 #95

merged 5 commits into from
Mar 3, 2019

Conversation

gutofoletto
Copy link
Contributor

@gutofoletto gutofoletto commented Feb 13, 2019 •
edited
Loading

Translated the React Without ES6 section as mentioned in #1

abnersajr
abnersajr suggested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@abnersajr abnersajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algumas pequenas sugestões mas no geral 👍

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@gutofoletto
Copy link
Contributor Author

Thanks @abnersajr!

@cezaraugusto cezaraugusto added the needs review A pull request ready to be reviewed label Feb 13, 2019
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 14, 2019
eduardomoroni
eduardomoroni previously approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show, uma sugestão seria colocar o link da wikipedia em pt-br

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@eduardomoroni eduardomoroni self-assigned this Feb 14, 2019
glaucia86
glaucia86 requested changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gutofoletto pequenas mudanças a serem feitas. Faz as alterações necessárias que logo em seguida estaremos aprovando a sua contribuição. Muito obrigada :)

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@gutofoletto
Copy link
Contributor Author

Thanks @glaucia86! I updated the PR with your suggestions yesterday ;)
Let me know if there is anything else ^^

@tesseralis tesseralis mentioned this pull request Feb 19, 2019
Closed
90 tasks
@tibuurcio tibuurcio added needs review A pull request ready to be reviewed feedback addressed and removed needs author response Changes requested needing author's input labels Feb 22, 2019
tibuurcio
tibuurcio requested changes Feb 24, 2019
View reviewed changes
Copy link
Collaborator

@tibuurcio tibuurcio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oi @gutofoletto, obrigado pelo tempo dedicado 😄

Seguem apenas algumas sugestões quanto a não traduzir state, que foi definido enquanto as traduções estavam acontecendo.. Após isso já podemos dar merge visto que você já aceitou as mudanças dos outros reviewers.

Valeu 👍

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@tibuurcio tibuurcio added needs author response Changes requested needing author's input and removed feedback addressed needs review A pull request ready to be reviewed labels Feb 24, 2019
@glaucia86
Copy link
Member

@gutofoletto faz as alterações que o @tibuurcio sugeriu ontem (24/02) que logo em seguida iremos aprovar a sua excelente contribuição. Nos sinalize aqui com

cc: @glaucia86 @tibuurcio

Que o quanto antes aprovaremos a sua contribuição! :)

@gutofoletto
Copy link
Contributor Author

@tibuurcio @glaucia86 done! ;)

@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit c89fdca

https://deploy-preview-95--pt-br-reactjs.netlify.com

1 similar comment
@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit c89fdca

https://deploy-preview-95--pt-br-reactjs.netlify.com

@tibuurcio tibuurcio added the needs +1 Needs another approval before merging label Feb 25, 2019
@tibuurcio tibuurcio added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 25, 2019
@gutofoletto
Copy link
Contributor Author

@glaucia86 Tem alguma coisa que preciso ajustar ainda?

glaucia86
glaucia86 approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gutofoletto Parabéns! A sua contribuição foi aprovada!
Agradecemos e muito pela sua ajuda!
LGTM 👍

Fazendo merge para a Documentação principal! :)

@glaucia86 glaucia86 merged commit 3760de7 into reactjs:master Mar 3, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed needs +1 Needs another approval before merging labels Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnersajr abnersajr abnersajr requested changes

@glaucia86 glaucia86 glaucia86 approved these changes

@jhonmike jhonmike jhonmike approved these changes

@tibuurcio tibuurcio tibuurcio approved these changes

@eduardomoroni eduardomoroni eduardomoroni left review comments

Assignees

@eduardomoroni eduardomoroni

@glaucia86 glaucia86

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gutofoletto @glaucia86 @eduardomoroni @abnersajr @jhonmike @tibuurcio @cezaraugusto