Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Portals to pt-BR #97

Merged
merged 12 commits into from
Feb 15, 2019
Merged

Translate Portals to pt-BR #97

merged 12 commits into from
Feb 15, 2019

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Feb 14, 2019

Feedback is welcome 😄

#1

Copy link
Member

@gmsecrieru gmsecrieru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ficou muito bom, parabéns! Fiz apenas alguns comentários/sugestões.

content/docs/portals.md Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
@gmsecrieru gmsecrieru self-assigned this Feb 14, 2019
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
@eduardomoroni eduardomoroni added the needs author response Changes requested needing author's input label Feb 14, 2019
@Rahmon
Copy link
Contributor Author

Rahmon commented Feb 14, 2019

Ficou muito bom, parabéns! Fiz apenas alguns comentários/sugestões.

Obrigado. Fiz as devidas alterações.

gmsecrieru
gmsecrieru previously approved these changes Feb 15, 2019
Copy link
Member

@gmsecrieru gmsecrieru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um último ajuste e pronto 👍

content/docs/portals.md Outdated Show resolved Hide resolved
gabrielbs
gabrielbs previously approved these changes Feb 15, 2019
Copy link
Contributor

@gabrielbs gabrielbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado \o/
Parabéns

@Rahmon Rahmon dismissed stale reviews from gabrielbs and gmsecrieru via f06e2d3 February 15, 2019 13:30
@halian-vilela halian-vilela added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 15, 2019
@halian-vilela
Copy link
Collaborator

@gabrielbs @gmsecrieru

Pessoal, que revisou, dá um Approve para fazermos o merge, por favor.

Aliás, tem uma questão interessante que percebi em outro commit. Se fizermos um novo push manual (fora da interface) que envia as correções depois de alguma aprovação, o GitHub remove as aprovações de review que haviam sido dadas.

Seria o caso de tentarmos fazer sempre os commits aqui pela interface? Para evitar o retrabalho de aprovar o que já estava aprovado?

@Rahmon
Copy link
Contributor Author

Rahmon commented Feb 15, 2019

@halian-vilela

eu fiz as alterações aqui pelo GitHub mesmo. Acho que qualquer commit dá um reset nas aprovações.

Isso faz sentido porque se um commit foi feito, algo mudou e precisa ser analisado e aprovado novamente.

@halian-vilela
Copy link
Collaborator

@halian-vilela

eu fiz as alterações aqui pelo GitHub mesmo. Acho que qualquer commit dá um reset nas aprovações.

Isso faz sentido porque se um commit foi feito, algo mudou e precisa ser analisado e aprovado novamente.

Sim, sim, faz sentido mesmo, o problema é que como estamos com o requisito de duas aprovações, as vezes só um aprovou, e aí se você subir as alterações do outro, ele reseta a do primeiro! Hehehehe

Então quer dizer que mesmo os commits por aqui resetam, né?

Blz. Já que os dois se manifestaram aí em cima, vou assumir que tá revisado!

Valeu!

@halian-vilela halian-vilela added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 15, 2019
Copy link
Contributor

@gabrielbs gabrielbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@halian-vilela halian-vilela merged commit 9f9f40e into reactjs:master Feb 15, 2019
@jhonmike jhonmike mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants