-
Notifications
You must be signed in to change notification settings - Fork 808
Commit
This makes the modal better follow aria guidelines for dialogs. It also gives screenreader users some identity for the modal after it opens. closes #236
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,8 @@ var Modal = React.createClass({ | |
closeTimeoutMS: React.PropTypes.number, | ||
ariaHideApp: React.PropTypes.bool, | ||
shouldCloseOnOverlayClick: React.PropTypes.bool, | ||
role: React.PropTypes.string | ||
role: React.PropTypes.string, | ||
contentLabel: React.PropTypes.string.isRequired | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
claydiffrient
Author
Contributor
|
||
}, | ||
|
||
getDefaultProps: function () { | ||
|
This is a breaking change? Why is this property now required?