Skip to content
This repository has been archived by the owner on Oct 26, 2018. It is now read-only.

syncHistoryWithStore doesn't work more than 100 times in Mobile Safari #393

Closed
amarchen opened this issue May 14, 2016 · 1 comment
Closed

Comments

@amarchen
Copy link

Mobile Safari has a known bug "by design" issue that does not update url over 100 times.
See https://forums.developer.apple.com/thread/36650 and http://jdurand.com/blog/2016/05/03/ember-history-pushstate-dom-exception-18/

For reproducing e.g. make url update on a slider move, then it's easy to generate 100 url updates by moving slider on the iPhone.

Therefore if you used syncHistoryWithStore after a 100 of updates, you'll be only getting security exception during the url update and in my case it also breaks further action processing (but that might be specific to my app).

Ember folks solved it by reloading the browser window http://jdurand.com/blog/2016/05/03/ember-history-pushstate-dom-exception-18/

@amarchen
Copy link
Author

I reported the issue in a more proper place: react-router - remix-run/react-router#3462

As for react-router-redux project, that is probably not the react-router-redux business to fix the router-Safari interaction, yet since it is still a problem a workaround could be possible. For example syncHistoryWithStore could provide optional throttling to update url not very often if underlying state changes very often (e.g. with a very tiny slider move) and browser is Mobile Safari.

@timdorr timdorr closed this as completed May 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants