Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximumAllowableTags for metrics with uri #794

Closed
violetagg opened this issue Jul 29, 2019 · 0 comments
Closed

Add maximumAllowableTags for metrics with uri #794

violetagg opened this issue Jul 29, 2019 · 0 comments
Labels
type/enhancement A general enhancement
Milestone

Comments

@violetagg
Copy link
Member

Even the URI itself can be unbounded in cardinality when path variables are used (e.g. /books/{bookId} with many different values of bookId). Is there any way in Reactor Netty to specify a template URI with path variables? Regardless, allowing high cardinality for tag values is not good as it will use increasingly more memory in the application and the metrics backend will also suffer. Micrometer offers a MeterFilter to limit the maximumAllowableTags, as can be seen used here in Spring Boot: https://github.com/spring-projects/spring-boot/blob/543fcdbbfdc807dd4cc70934b076756d80e2d21c/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/web/client/HttpClientMetricsAutoConfiguration.java#L53-L61

@violetagg violetagg added the type/enhancement A general enhancement label Jul 29, 2019
@violetagg violetagg added this to the 0.9.0.M4 milestone Jul 29, 2019
@violetagg violetagg modified the milestones: 0.9.0.RC1, 0.9.0.RC2 Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant