Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for IllegalReferenceCountException/sendObject #2821

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Jun 7, 2023

This PR only contains a test in order to check if the Netty #13388 fix from 4.1.93.Final version is fixing the use case described in #2760.

Fixes #2760

@pderop pderop added the type/test A general test label Jun 7, 2023
@pderop pderop added this to the 1.0.33 milestone Jun 7, 2023
@pderop pderop self-assigned this Jun 7, 2023
@pderop pderop added the for/netty This belongs to the Netty project label Jun 7, 2023
@pderop
Copy link
Contributor Author

pderop commented Jun 7, 2023

@violetagg ,

can you take a look (the failure from windows-2019 is not related) ?

If you replace nettyDefaultVersion from build.gradle by 4.1.92.Final, then the test is expected to fail.

thanks.

@pderop pderop requested a review from violetagg June 7, 2023 10:29
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@pderop
Copy link
Contributor Author

pderop commented Jun 7, 2023

@violetagg , thanks !

@pderop pderop merged commit c71390e into reactor:1.0.x Jun 7, 2023
@pderop pderop deleted the 1.0.x-test-2760 branch June 7, 2023 12:19
pderop added a commit that referenced this pull request Jun 7, 2023
@violetagg violetagg removed the for/netty This belongs to the Netty project label Jun 7, 2023
pderop added a commit that referenced this pull request Jun 7, 2023
@violetagg violetagg changed the title Add test for IllegalReferenceCountException/sendObject Add test for IllegalReferenceCountException/sendObject Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/test A general test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants