-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement communication via Unix domain sockets (UDS) #46
Comments
This is actually ready, this very likely only requires some tests and documentation 👍 |
Functionally, this has been ready for years, for example I've been using with via https://github.com/clue/php-buzz-react#unix-domain-sockets for https://github.com/clue/php-docker-react, but I've never been quite happy with this API. The question remains: How (whether?) should this be exposed to the API of this project. This project is designed around the concept of URLs for sending HTTP requests either via plaintext TCP/IP or secure TLS sockets. For UDS, we essentially need to do the same thing, but only over UDS sockets. Docker for example has a single listening socket under
If we were to expose this functionality through our API, what URL should be passed here? Also, do we really want any outside location to be able to redirect to such an URL? Hint: We probably do not want this. Also, should we assume As such, it's my understanding that UDS should probably not be enabled by default unless explicitly configured. Instead of breaking the existing API I would suggest using some kind of hostname-to-UDS-mapping so that the HTTP API does not really notice this at all. For example, this would allow the consumer of this package to explicitly map What do you think? Any input would be much appreciated! 👍 |
They all share that UDS support has to be configured explicitly and is not enabled by default. The all also only support a single path, which means that once configured, every request will be sent to the given UDS path. I think a similar approach would work fine here. As such, I've just filed reactphp/socket#117 which would allow creating an explicit connector instance which can be passed to the |
Depends on reactphp-legacy/socket-client#41
The text was updated successfully, but these errors were encountered: