Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP client: Support HTTP upgrades (WebSockets) #376

Open
clue opened this issue Jul 12, 2020 · 2 comments
Open

HTTP client: Support HTTP upgrades (WebSockets) #376

clue opened this issue Jul 12, 2020 · 2 comments

Comments

@clue
Copy link
Member

clue commented Jul 12, 2020

This library should provide support for HTTP upgrades (WebSocket etc.) using the Connection: upgrade and Upgrade: websocket headers.

This is already supported on the server-side (see #190), so adding support for this on the client-side should be reasonable. This will likely require a dedicated API as the existing streaming APIs only expose a ReadableStreamInterface and the upgraded stream would have to be a DuplexStreamInterface.

We welcome contributions, reach out if you want to support this project 👍

@bosunski
Copy link

The good news is that I was able to have a working implementation of this during the weekend 😀. I'm currently testing and hope to get a PR in by tomorrow.

@mpociot
Copy link

mpociot commented Jul 21, 2024

@clue Are there any plans to add this feature?
I'd love to add the ability to forward websocket connections to Expose, but those requests currently get closed immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants