Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename await() to timeout() #10

Closed
clue opened this issue Jul 2, 2015 · 1 comment
Closed

Rename await() to timeout() #10

clue opened this issue Jul 2, 2015 · 1 comment
Labels
easy pick maintenance

Comments

@clue
Copy link
Member

clue commented Jul 2, 2015

After talking to @jsor about #2 we agree that the name await() implies a similarity with the await keyword in ES6/HHVM.

The function name "Timeout\await()" combined makes sense, but not in isolation. As a first step, let's rename this to "Timeout\timeout()".

Obviously, this isn't ideal either, so we should also rename the namespace…
This was referenced Jul 2, 2015
Closed
Closed
@jsor
Copy link
Member

jsor commented Jul 3, 2015

👍

@clue clue mentioned this issue Jul 3, 2015
Closed
@clue clue closed this as completed in b0fe41b Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsor @clue