Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: loosening up our @readme/variable peerDep #131

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 24, 2021

🧰 Changes

This loosens up the version constraints on our @readme/variable peerDep as right now that package is the API Explorer repo and occasionally receives a version bump when we update dev dependencies, and right now when that happens we receive this error on npm@7 when doing installs:

$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @readme/[email protected]
npm ERR! Found: @readme/[email protected]
npm ERR! node_modules/@readme/variable
npm ERR!   dev @readme/variable@"^12.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @readme/variable@"^11.0.0" from @readme/[email protected]
npm ERR! node_modules/@readme/markdown
npm ERR!   dev @readme/markdown@"^6.21.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/jon/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/jon/.npm/_logs/2021-02-24T01_11_35_822Z-debug.log

@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-131 February 24, 2021 01:19 Inactive
@erunion
Copy link
Member Author

erunion commented Feb 24, 2021

Maybe that package should be in its own repository so it only gets bumped when we make actual, non devDep, changes to it?

package.json Show resolved Hide resolved
@rafegoldberg
Copy link
Contributor

rafegoldberg commented Feb 24, 2021

@erunion wrt/your comment, will @readme/variable be bumped every time we roll a release to the API Explorer monorepo? Because in that case, yeah—might be nice to minimize the lockfile changes that'll create all over the place. But not a big deal at first blush, I think?

@erunion
Copy link
Member Author

erunion commented Feb 24, 2021

@rafegoldberg No it only gets bumped if devDependencies like ESLint or whatever get updated. It's been getting major version bumps lately with the big work we've been doing because those deps have been bumped as part of that work.

That library is mostly static so maybe in the long run it'll be good to pull it out of the general explorer repo, but if loosening up this peerDep requirement makes the error go away, I'm cool with that for now.

@erunion erunion merged commit 104e21d into next Feb 24, 2021
@erunion erunion deleted the chore/loosen-variable-reqs branch February 24, 2021 17:55
rafegoldberg pushed a commit that referenced this pull request Feb 24, 2021
## Version 6.26.1

### 🛠 Fixes & Updates

* loosening up our @readme/variable peerDep ([#131](#131)) ([104e21d](104e21d))

### ✨ New & Improved

* fix glossary term overflow in tables ([#108](#108)) ([52e8d9e](52e8d9e))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.26.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants