Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: html in callouts #135

Merged
merged 6 commits into from
Mar 2, 2021
Merged

fix: html in callouts #135

merged 6 commits into from
Mar 2, 2021

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Mar 2, 2021 •
edited
Loading

Fixes CX-76

🧰 Changes

This fixes rendering html in callouts. The regex to trim the blockquote leaders > was also trimming the ending bracket of the html tags.

🧬 QA & Testing

@linear
Copy link

linear bot commented Mar 2, 2021

CX-76 fix: allow whitelisted HTML markup in RDMD Callouts.

@lamberto pointed out that even whitelisted whitelisted markup is rendering as plain text. when they should be interpreted as proper HTML tags!

@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-135 March 2, 2021 00:53 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-135 March 2, 2021 00:54 Inactive
@kellyjosephprice kellyjosephprice changed the title Bugs/html in callouts fix: html in callouts Mar 2, 2021
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-135 March 2, 2021 18:16 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-135 March 2, 2021 18:22 Inactive
@kellyjosephprice kellyjosephprice temporarily deployed to markdown-pr-135 March 2, 2021 18:26 Inactive
@kellyjosephprice kellyjosephprice requested review from rafegoldberg, a team and billhimmelsbach and removed request for a team March 2, 2021 18:28
rafegoldberg
rafegoldberg approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope!

@kellyjosephprice kellyjosephprice merged commit aee4b91 into next Mar 2, 2021
@kellyjosephprice kellyjosephprice deleted the bugs/html-in-callouts branch March 2, 2021 18:35
rafegoldberg pushed a commit that referenced this pull request Mar 2, 2021
@semantic-release-bot
🚀 v6.26.2-next.1 🦉
8697f6b 
## Version 6.26.2-next.1

### 🛠 Fixes & Updates

* html in callouts ([#135](#135)) ([aee4b91](aee4b91))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.26.2-next.1

rafegoldberg pushed a commit that referenced this pull request Mar 2, 2021
@semantic-release-bot
🚀 v6.26.2 🦉
46f976d 
## Version 6.26.2

### 🛠 Fixes & Updates

* html in callouts ([#135](#135)) ([aee4b91](aee4b91))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.26.2

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellyjosephprice @rafegoldberg