fix(compat): replace matchAll to support iOS safari <= 12 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
approved these changes
Jun 15, 2021
.github/workflows/ci.yml
Outdated
Comment on lines
31
to
33
| #- name: Update regression test snapshots | ||
| #if: ${{ failure() }} | ||
| #run: npm run test.browser -- -u |
There was a problem hiding this comment.
Don't we need to update these visual snapshots in order to get tests to pass?
| @@ -6,7 +6,11 @@ const PropTypes = require('prop-types'); | |||
| const MATCH_SCRIPT_TAGS = /<script\b[^>]*>([\s\S]*?)<\/script>\n?/gim; | |||
|
|
|||
| const extractScripts = (html = '') => { | |||
| const scripts = [...html.matchAll(MATCH_SCRIPT_TAGS)].map(m => m[1]); | |||
There was a problem hiding this comment.
We should probably polyfill missing native methods like this in the long run.
There was a problem hiding this comment.
I don't understand babel, but shouldn't it already be:
$ cat .babelrc
{
"presets": [
[
"@babel/preset-env",
{
"targets": {
"browsers": ["last 2 versions"]
}
}
],
"@babel/preset-react"
],
"plugins": [
"@babel/plugin-proposal-class-properties",
"@babel/plugin-proposal-object-rest-spread",
"@babel/plugin-proposal-optional-chaining"
]
}
|
This PR was released!🚀 Changes included in v6.27.2-next.2 |
rafegoldberg
pushed a commit
that referenced
this pull request
Jun 15, 2021
|
This PR was released!🚀 Changes included in v6.27.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
matchAllfirst came to iOS safari in version 13.🧬 QA & Testing