Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned callout blocks lose data. #35

Closed
rafegoldberg opened this issue May 1, 2020 · 1 comment
Closed

Pinned callout blocks lose data. #35

rafegoldberg opened this issue May 1, 2020 · 1 comment
Assignees

Comments

@rafegoldberg
Copy link
Contributor

Asana

In certain scenarios when a callout is pinned to the sidebar, like so...

image

...it seems to loose it's content on render:

image

This is likely to do with the way I've set up the callout AST, which requires some hoop-thru-jumping to parse out the icon and title text from the rest of the children content:

https://github.com/readmeio/api-explorer/blob/2cfc9160a46293b07574d49c2a255f783afd1a90/packages/markdown/components/Callout/index.jsx#L18

@rafegoldberg rafegoldberg self-assigned this May 1, 2020
@rafegoldberg rafegoldberg changed the title Last pinned blocks loose data. Last pinned blocks lose data. May 1, 2020
@rafegoldberg rafegoldberg changed the title Last pinned blocks lose data. Pinned blocks lose data. May 1, 2020
@rafegoldberg rafegoldberg changed the title Pinned blocks lose data. Pinned callout blocks lose data. May 1, 2020
@rafegoldberg rafegoldberg transferred this issue from readmeio/api-explorer Aug 4, 2020
@kellyjosephprice
Copy link
Collaborator

I'm closing this as I believe it is now fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants