Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify RDMD production builds. #38

Open
rafegoldberg opened this issue Apr 27, 2020 · 1 comment
Open

Minify RDMD production builds. #38

rafegoldberg opened this issue Apr 27, 2020 · 1 comment
Assignees
@rafegoldberg

Comments

@rafegoldberg
Copy link
Contributor

I set up TerserWebpackPlugin to run on our builds a while back, but for some reason the minified output would break the ReadMe app whenever I imported it!

https://github.com/readmeio/api-explorer/blob/67ebc1dde38871bee0c8127166ae3dd90668051d/packages/markdown/webpack.config.js#L18-L27

Didn't quite determine what was causing this issue, but we should get back to it ASAP so we can reenable minification.
@rafegoldberg rafegoldberg self-assigned this Apr 27, 2020
@rafegoldberg
Copy link
Contributor Author

(cc: @dok — of note wrt/our discussion re: bundle size!)

@rafegoldberg rafegoldberg transferred this issue from readmeio/api-explorer Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafegoldberg rafegoldberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafegoldberg