fix(code): copying interpolated variables #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Code component uses the syntax-highlighter for variable interpolation, but it was passing the uninterpolated text to the copy function.
kellyjosephprice
requested review from
a team,
dok and
kunal-pathak
and removed request for
a team
There was a problem hiding this comment.
@kellyjosephprice this looks pretty solid to me and like a positive change, but I don't have a ton of context in this area yet, so I'm gonna add @rafegoldberg in addition to myself!
rafegoldberg
approved these changes
Nov 18, 2020
| const copyClass = `${rootClass}_copied`; | ||
| const button = React.createRef(); | ||
| /* istanbul ignore next */ | ||
| const copier = () => { | ||
| const code = codeRef.current.textContent; |
There was a problem hiding this comment.
Let me double check. I tested before writing the tests and stuff.
There was a problem hiding this comment.
Ok, after much linkage, it works for me locally.
|
This PR was released!🚀 Changes included in v6.22.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
The Code component uses the syntax-highlighter for variable
interpolation, but it was passing the uninterpolated text to the copy
function.