Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toc #900

Merged
merged 15 commits into from
Jun 6, 2024
Merged

fix: toc #900

merged 15 commits into from
Jun 6, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

PR App Fix RM-XYZ

🧰 Changes

Refactors how we create the table of contents.

Previously, the TOC work changed the arguments and returns of compile and run to use VFile's instead of string's. This rewrites that to instead write the toc data into the compiled components so it can be exported at run-time.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta June 6, 2024 17:41
@kellyjosephprice kellyjosephprice marked this pull request as ready for review June 6, 2024 22:11
trishaprile
trishaprile approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@trishaprile trishaprile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very out of my depth but tested locally and looks wonderful 🕺

@kellyjosephprice kellyjosephprice merged commit b3e8f7d into beta Jun 6, 2024
9 of 11 checks passed
@kellyjosephprice kellyjosephprice deleted the kp/fix/toc branch June 6, 2024 23:28
rafegoldberg pushed a commit that referenced this pull request Jun 6, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.51 🦉
d523557 
## Version 6.75.0-beta.51

### ✨ New & Improved

* plain ([#898](#898)) ([0b60259](0b60259))

### 🛠 Fixes & Updates

* toc ([#900](#900)) ([b3e8f7d](b3e8f7d))
* types ([86a199b](86a199b))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.51

@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishaprile trishaprile trishaprile approved these changes

@Dashron Dashron Awaiting requested review from Dashron

@jennspencer jennspencer Awaiting requested review from jennspencer

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyjosephprice @rafegoldberg @trishaprile