Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compatibility for rdmd image/embed components #919

Merged

Conversation

jennspencer
Copy link
Contributor

PR App Fix RM-10134

🧰 Changes

Converts the rdmd-style mdast for the image and embed blocks to the new MDX components

🧬 QA & Testing

Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

};

expect(mdx(ast).trim()).toBe(
'<Image align="center" border="true" caption="hello **cat**" width="300px" src="https://drastik.ch/wp-content/uploads/2023/06/blackcat.gif" />',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈‍⬛

@jennspencer jennspencer merged commit e631c8f into beta Jun 27, 2024
9 of 11 checks passed
@jennspencer jennspencer deleted the jenn/rm-10134-compatibility-for-embed-and-image-blocks branch June 27, 2024 20:52
rafegoldberg pushed a commit that referenced this pull request Jun 27, 2024
## Version 6.75.0-beta.65

### ✨ New & Improved

* compatibility for rdmd image/embed components ([#919](#919)) ([e631c8f](e631c8f))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants