Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beta): reset callout headings to H2s #941

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Jul 16, 2024

📖 PR App

🧰 Changes

RMDX wraps callout headings in <h3> tags, but historically, RDMD has marked these up as <h2>s. (Not sure if there was a reason for this change, but it's making it hard to tell which docs will actually be impacted by the migration!)

  • make RMDX callout headings use an <h2>

@rafegoldberg rafegoldberg added the refactor Issues about tackling technical debt label Jul 16, 2024
Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can only find related conversations. We probably forked beta when it was h3, but we changed next to an h2???

@rafegoldberg rafegoldberg merged commit 08220ba into beta Jul 30, 2024
8 checks passed
@rafegoldberg rafegoldberg deleted the fix/beta/reset-callout-headings-to-h2s branch July 30, 2024 10:01
rafegoldberg pushed a commit that referenced this pull request Jul 30, 2024
## Version 6.75.0-beta.79

### 🛠 Fixes & Updates

* **beta:** reset callout headings to H2s ([#941](#941)) ([08220ba](08220ba)), closes [/github.com/readmeio/markdown/blob/ad07529eef2513e83072dc31f0469a5f36603957/components/Callout/index.jsx#L11](https://github.com/readmeio//github.com/readmeio/markdown/blob/ad07529eef2513e83072dc31f0469a5f36603957/components/Callout/index.jsx/issues/L11)

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

This PR was released!

🚀 Changes included in v6.75.0-beta.79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues about tackling technical debt released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants