fix: saving tables #942
Merged
fix: saving tables #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
force-pushed
the
fix/saving-tables
branch
from
cab26e5
to
b45927f
Compare
rafegoldberg
approved these changes
Jul 18, 2024
| @@ -35,7 +40,10 @@ const visitor = (table: Table, index: number, parent: Parents) => { | |||
| }; | |||
|
|
|||
| visit(table, 'tableCell', tableCellVisitor); | |||
| if (!hasFlowContent) return; | |||
| if (!hasFlowContent) { | |||
| table.type = 'table'; | |||
There was a problem hiding this comment.
Ohhh is this where the tableau error was coming from?
There was a problem hiding this comment.
Yea, I added a custom table component, silly-ly named tableau, to handle block content. I believe I ran into some weirdness the last time I tried to override a built in type.
And yea, I forgot to add a compiler or transform it or anything.
Well, it's mostly just looking for any block content in a table cell. Except for the case when the editor likes to wrap the table cell content in a |
|
This PR was released!🚀 Changes included in v6.75.0-beta.76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes saving 'complex' tables.
In a prior PR, I added a new node type
tableauto represent tables with block content. This mostly worked for the editor, but not when doingmdx(mdast(doc)). This PR adds a transformer, so the atableauis converted to a JSX table just like regulartable's.This also adds the check so, if a
tableauno longer has block content, it's saved as markdown!🧬 QA & Testing
Hard to test outside the main app.