chore(rdmd to rmdx): wrap scripts + styles in an <HTMLBlock> #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rafegoldberg
added a commit
that referenced
this pull request
Aug 27, 2024
rafegoldberg
added a commit
that referenced
this pull request
Aug 27, 2024
rafegoldberg
force-pushed
the
chore/rdmd-to-mdx-conversion/wrap-script+style-tags
branch
from
bf97d12
to
cf2e306
Compare
rafegoldberg
force-pushed
the
chore/rdmd-to-mdx-conversion/wrap-script+style-tags
branch
from
cf2e306
to
da79e25
Compare
kellyjosephprice
approved these changes
Aug 27, 2024
compatability mode has been deprecated for RMDX so raw `<script>` tags should never be executed
rafegoldberg
force-pushed
the
chore/rdmd-to-mdx-conversion/wrap-script+style-tags
branch
from
37e77fa
to
12e7e66
Compare
rafegoldberg
deleted the
chore/rdmd-to-mdx-conversion/wrap-script+style-tags
branch
rafegoldberg
pushed a commit
that referenced
this pull request
Sep 10, 2024
|
This PR was released!🚀 Changes included in v7.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
implementcompatabilityModeoptiondiscussed with @kellyjosephprice and we're gonna deprecate compat mode for RMDX (8ad57ac)
🧬 QA & Testing
Pull this branch down and try running the test suite for the RDMD→MDX conversion:
If these new tests pass, this worked! 🎉