fix: image migration issues #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafegoldberg
approved these changes
Sep 11, 2024
processor/utils.ts
Outdated
Comment on lines
69
to
70
| if (typeof attr.value === 'string' || attr.value === null) { | ||
| memo[attr.name] = attr.value; |
There was a problem hiding this comment.
So we intentionally want to set the attribute to null here? May I ask why?
There was a problem hiding this comment.
I wasn't sure what to do with it. But I think it should actual set the value to true
|
This PR was released!🚀 Changes included in v7.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes some issues when migrating images.
mdastwas sometimes not correctly populating image attributes. I tried to make it more normal, so the attributes are copied to both the node and the hProperties. 🤷a
nullattribute could crash the transormers. I've added a null check, as well as filtered out empty attributes.🧬 QA & Testing
This should probably be tested in the main app so we get the full integrations.