feat: fontawesome 6 #969
Merged
feat: fontawesome 6 #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runnabro
requested review from
kellyjosephprice,
rafegoldberg and
trishaprile
kellyjosephprice
approved these changes
Sep 24, 2024
Thanks! I had to update the text to change how the fa stuff would work :) |
rafegoldberg
approved these changes
Sep 25, 2024
| @@ -102,7 +102,7 @@ | |||
| } | |||
| @mixin calloutCustomIcons($R: callout) { | |||
| --emoji: 1em; | |||
| --icon-font: FontAwesome; | |||
| --icon-font: var(--fa-style-family, 'Font Awesome 6 Pro'); | |||
There was a problem hiding this comment.
Wait, will this --fa-style-family var allow users to customize the FontAwesome style automagically? And if so, why do we need to add the extra class elsewhere?
There was a problem hiding this comment.
Yes! This is one way you can customize the icon style, but it would apply across all uses of FA. Would make it harder to mix-and-match. It’s also probably lesser known, since they don’t make it very prominent.
There was a problem hiding this comment.
Oh sick, so much cleaner than having to add a million extra classes.
|
This PR was released!🚀 Changes included in v7.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Should be able to have this go live before the
readmechanges. Keeping the (no longer used).faclasses should be enough for backwards compatibility.🧬 QA & Testing