Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdme docs does not handle symlinks properly #942

Open
NiankSoft opened this issue Nov 25, 2023 · 1 comment
Open

rdme docs does not handle symlinks properly #942

NiankSoft opened this issue Nov 25, 2023 · 1 comment
Labels
command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands enhancement New feature or request

Comments

@NiankSoft
Copy link

Assuming we have this folder structure:

.
├── a
│   └── a.md
└── b
    ├── a -> ../a/
    └── b.md

  • rdme docs a will upload a.md as expected
  • rdme docs b will upload b.md and completely ignore the folder structure (I expect a.md to be there as well)
  • rdme docs b/a will upload a.md but the logging seems broken (updating files are blank lines):
🔑 [email protected] is currently logged in, using the stored API key for this project: xxx
`aa` was not updated because there were no changes.
`bb` was not updated because there were no changes.
✏
`dd` was not updated because there were no changes.

To build the folder structure above:

mkdir a b
touch a/a.md # Of course, we need at least the yaml header in there, to actually test it
touch b/b.md
cd b
ln -s ../a ./
@kanadgupta kanadgupta added enhancement New feature or request command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands labels Nov 27, 2023
@kanadgupta
Copy link
Member

Thanks for writing in @NiankSoft! Symlinks are a use-case we hadn't really considered. Will post any updates to this thread as we have 'em!

@NiankSoft NiankSoft changed the title rdme docs does handle symlinks properly rdme docs does not handle symlinks properly Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants