Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set "Domain has SSL" on a domain to force us to redirect to https #2236

Closed
ericholscher opened this issue Jun 2, 2016 · 4 comments · Fixed by #4483
Closed
Labels
Improvement Minor improvement to code

Comments

@ericholscher
Copy link
Member

Currently when you hit https://python-hyper.org/projects/hpack/ the redirect points at http. We assume all domains are HTTP only, because we don't do SSL internally. At least add metadata to the Domain that so we can properly redirect to https.

@agjohnson agjohnson added the Improvement Minor improvement to code label Jun 24, 2016
@nijel
Copy link
Contributor

nijel commented Jun 27, 2017

This would be really great to have this configurable, at least until #2652 is implemented.

@humitos
Copy link
Member

humitos commented Aug 7, 2018

Just want to mention before #4483 gets merged and deployed, than hitting https://python-hyper.org/hpack/en/latest/ I'm not redirected to HTTP only. I'm not sure if we have changed something since Jun...

cc @davidfischer

@davidfischer
Copy link
Contributor

This domain appears to have a different setup. It is not setup with the normal Read the Docs custom domain instructions. This domain is using a naked domain (an A record, not a CNAME) and is probably doing their own proxying to Read the Docs.

I believe that this issue is more about generating "http" links (as opposed to "https" links).

@davidfischer
Copy link
Contributor

I believe that this issue is more about generating "http" links (as opposed to "https" links).

Actually I think I read this one wrong. You are right @humitos and this issue doesn't seem to be an issue anymore in terms of redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants