Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete untracked tags on fetch step #4258

Closed
stsewd opened this issue Jun 18, 2018 · 4 comments
Closed

Delete untracked tags on fetch step #4258

stsewd opened this issue Jun 18, 2018 · 4 comments
Assignees
Labels
Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Jun 18, 2018

Currently, if the user deletes a tag, it needs to wipe the environment for this change be reflected in their version list.

There are some solutions to delete untracked tags (require more than 2 commands). But I found that the newest version of git has the --prune-tags option, which is used as git fetch --prune --prune-tags (git >2.17). We need to update git on the servers (we use 2.7.4) and change the fetch command. Or we can find a way to wipe the environment if we detect something like this case.

Raised in #3913 (comment)

@humitos
Copy link
Member

humitos commented Jul 29, 2018

I think we can implement the command you mentioned here very soon since we are migrating our servers to Ubuntu 18.04 which includes 2.17.1 by default: https://packages.ubuntu.com/bionic/git

The PR needed for this should be very simple and shouldn't have any secondary effect :)

I'm 👍 on adding the --prune-tags to our current command.

@agjohnson agjohnson added the Status: blocked Issue is blocked on another issue label Sep 20, 2018
@agjohnson
Copy link
Contributor

Blocking until .com update to 18.04

@stsewd stsewd removed the Status: blocked Issue is blocked on another issue label Oct 25, 2018
@stsewd stsewd self-assigned this Oct 25, 2018
@stsewd stsewd added Improvement Minor improvement to code and removed Needed: design decision A core team decision is required labels Oct 25, 2018
@ericholscher ericholscher reopened this Nov 6, 2018
@ericholscher
Copy link
Member

Believe that #4811 didn't totally fix this. Reopening for now.

@stsewd
Copy link
Member Author

stsewd commented Nov 6, 2018

So, tags are being deleted, the sync version bug is because of another problem, I opened #4875

@stsewd stsewd closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants