Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor remove_dir and clear_artifacts #4297

Closed
humitos opened this issue Jun 25, 2018 · 0 comments
Closed

Refactor remove_dir and clear_artifacts #4297

humitos opened this issue Jun 25, 2018 · 0 comments
Assignees
@stsewd
Labels
Improvement Minor improvement to code
Milestone
Cleanup

Comments

@humitos
Copy link
Member

humitos commented Jun 25, 2018

This was risen in #4296 (comment) since it seems that we can have a better names for these tasks and probably merge them into just one.

We could have a function helper that triggers remove_dir with the proper PATHs given a Version object or similar instead of calling all the times with the get_artifact_paths maybe.

Related #3775
@humitos humitos added the Improvement Minor improvement to code label Jun 25, 2018
@humitos humitos added this to the Cleanup milestone Jun 25, 2018
@stsewd stsewd self-assigned this Dec 13, 2018
@stsewd stsewd mentioned this issue Dec 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsewd stsewd

Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
2 participants
@humitos @stsewd