Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores the conf.py path on some builds #4360

Closed
lazka opened this issue Jul 12, 2018 · 12 comments
Closed

Ignores the conf.py path on some builds #4360

lazka opened this issue Jul 12, 2018 · 12 comments
Labels
Needed: replication Bug replication is required Support Support question

Comments

@lazka
Copy link
Contributor

lazka commented Jul 12, 2018

Details

Expected Result

I've set a custom conf.py path in the advanced settings (for some years now)
I expect it to be always used to build the docs.

Actual Result

Since a week (this has happened at least 3 times now) it sometimes ignores the custom path and just uses "conf.py" which results in an empty/default documentation.

Good build: https://readthedocs.org/projects/quodlibet/builds/7472492/
Bad build: https://readthedocs.org/projects/quodlibet/builds/7473196/

@lazka
Copy link
Contributor Author

lazka commented Jul 12, 2018

I've done a few more rebuilds now and it seems just random, sometimes it uses the path sometimes not.

@lazka
Copy link
Contributor Author

lazka commented Jul 12, 2018

I've removed the fixed conf.py path from the settings now and it still randomly finds the conf.py and sometimes not.

@ericholscher
Copy link
Member

This is happening because you have a tag named latest, which doesn't have any of your docs checked into it: https://github.com/quodlibet/quodlibet/tree/latest

I'm not sure why it's happening sporadically though.

@ericholscher
Copy link
Member

Believe this is an outcome of our updated version handling code: #3913

I was looking at the versions in the admin, and accidentally overwrote the latest version, losing the build history (so the links above don't work). I've re-created latest properly, and am testing on my local instance to see how we can fix it.

@lazka
Copy link
Contributor Author

lazka commented Jul 12, 2018

This is happening because you have a tag named latest

Ah, that's a dummy tag I use for hosting binaries used by CI for the master branch. But that tag exists for some time now.

Thanks for looking into this.

@stsewd
Copy link
Member

stsewd commented Jul 12, 2018

But that tag exists for some time now.

We update the version handling to fix another bug. So, now if rtd finds a tag/branch named stable or latest that replace to the rtd default tags (where rtd automatically creates the stable and latest version).

@stsewd
Copy link
Member

stsewd commented Jul 12, 2018

I don't know the exact problem (I can't see the build history), but I would think this is as Eric mentions a problem with your tag. When you build docs for latest the original conf.py can't be found, when you build another version it can be found. The solution: you'll need to remove/rename the latest tag.

@stsewd stsewd added the Support Support question label Jul 12, 2018
@lazka
Copy link
Contributor Author

lazka commented Jul 13, 2018

good: https://readthedocs.org/projects/quodlibet/builds/7476273/
bad: https://readthedocs.org/projects/quodlibet/builds/7480432/

I think the difference is that the good build is triggered through a settings change in the rtd UI and the other one is triggered through the "Build Version" button.

If me removing the "latest" tag on the repo doesn't hinder you from debugging this I'll rename it.

@ericholscher
Copy link
Member

Go ahead and remove it. 👍

We can create a test repo with a latest tag to test against.

@stsewd
Copy link
Member

stsewd commented Jul 13, 2018

@lazka I see, in the first build it builds from master and on the second it builds from the latest tag. This should only happen once. After building master the versions are refreshed and the rtd latest point to the latest tag, not to master. If the rtd latest point back to master without removing the latest tag from the repo, well that is a weird bug.

Can you confirm this is happening more than one time for latest?

@lazka
Copy link
Contributor Author

lazka commented Jul 13, 2018

@stsewd not sure. I'd guess changing settings clears some version cache so it builds master once again and then latest from there on like you said.

@stsewd stsewd added the Needed: replication Bug replication is required label Jul 13, 2018
@stsewd
Copy link
Member

stsewd commented Nov 29, 2018

Closing in favor of #4876

@stsewd stsewd closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: replication Bug replication is required Support Support question
Projects
None yet
Development

No branches or pull requests

3 participants