Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 support #4543

Closed
stsewd opened this issue Aug 20, 2018 · 6 comments
Closed

Drop python 2 support #4543

stsewd opened this issue Aug 20, 2018 · 6 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone

Comments

@stsewd
Copy link
Member

stsewd commented Aug 20, 2018

We are already running python3 in production and python2 support is ending. We can drop the python2 compatibility layer (from isort for example), and also don't run python2 on Travis, instead start testing with python 3.7

@stsewd stsewd added the Needed: design decision A core team decision is required label Aug 20, 2018
@ericholscher
Copy link
Member

I'm +1 on this. The corporate side is still Python 2, so that is the primary blocker currently, but I'm +1 on it after that.

@ericholscher ericholscher added the Status: blocked Issue is blocked on another issue label Aug 21, 2018
@stsewd
Copy link
Member Author

stsewd commented Aug 24, 2018

Just linking to some tools that can help with the cleanup

@davidfischer
Copy link
Contributor

I'm a definite +1 on dropping support for Python2. Supporting both comes at a cost. I have a few notes:

  • Dropping support should involve a major rev (eg. v3.0.0).
  • We might want to drop dual Python support at a specific date (eg. January 1, 2019). I don't think this is super critical but for 3rd parties who take our code that might be nice.
  • I assume we'll discontinue use of six and future (we use both) and we'll slowly clean up code that uses them.

@agjohnson
Copy link
Contributor

Agreed on lumping this into v3.0, moving discussion here to our on-going discussion on deprecation #4594

@agjohnson agjohnson added this to the 3.0 milestone Nov 10, 2018
@agjohnson agjohnson removed Needed: design decision A core team decision is required Status: blocked Issue is blocked on another issue labels Nov 10, 2018
@agjohnson agjohnson reopened this Nov 10, 2018
@agjohnson
Copy link
Contributor

Nevermind, breaking out a discrete ticket! We'll address this at v3 at the end of the year.

@stsewd
Copy link
Member Author

stsewd commented Nov 11, 2018

I opened readthedocs/common#19 and readthedocs/common#20 to help with the removal of the python2 layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

5 participants