Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version's page is slow #6070

Closed
stsewd opened this issue Aug 13, 2019 · 6 comments · Fixed by #6224
Closed

Version's page is slow #6070

stsewd opened this issue Aug 13, 2019 · 6 comments · Fixed by #6224

Comments

@stsewd
Copy link
Member

stsewd commented Aug 13, 2019

Currently, we list all versions in one page. This is a problem for projects that have thousands of versions (it's difficult to search the versions and very slow for the db)

https://readthedocs.org/projects/docs/versions/

One idea is to don't list deactivated versions and use a form instead. Not really sure how that looks like, we still need a way to list all versions. If we put an auto complete widget, does the user know what version wants to activate?

Ref #6068 (comment)

@stsewd stsewd added the Needed: design decision A core team decision is required label Aug 13, 2019
@dojutsu-user
Copy link
Member

We can have infinite scroll?

@davidfischer
Copy link
Contributor

This page's performance is tied to #3712. Generally each active version results in ~3 extra DB queries because it links to those versions' docs. Having even a couple hundred inactive versions shouldn't matter, but active versions definitely will.

@agjohnson
Copy link
Contributor

I'm -1 on pagination and infinite scroll, or other patterns that continue showing inactive versions listed on this page. The pattern used here should be the same as our other CRUD UIs:

  • The version list is only active versions
  • A button at the top will lead to a form
  • The form has an autocomplete text input to select the version, form submit adds Version.active = True to the selected version
  • The newly selected Version.active = true version is now on the version list page.

@cz-kialo
Copy link

cz-kialo commented Sep 6, 2019

Just wanted to leave a comment here that this issue prevents us from defining more that one version (the default version) on readthedocs.com . Because of our continuous integration setup we have several ten-thousand tags in our repo on Github and the versions page just times-out with a 502 error.

A simple form to define a new version would be great.

@humitos
Copy link
Member

humitos commented Sep 9, 2019

@cz-kialo please, if you are using Read the Docs for Business contact us via the support email (support at readthedocs.com) and we will help you with this there. Thanks!

@cz-kialo
Copy link

cz-kialo commented Sep 9, 2019

@humitos thanks, we're already in contact with your support since some time, just wanted to make sure that the info is taken into account because this issue seems to get some attention at the moment.

@davidfischer davidfischer removed the Needed: design decision A core team decision is required label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants