Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SHOW READYSET METRICS to display all metrics #1355

Open
altmannmarcelo opened this issue Aug 21, 2024 · 0 comments
Open

Create SHOW READYSET METRICS to display all metrics #1355

altmannmarcelo opened this issue Aug 21, 2024 · 0 comments
Labels
Medium priority Created by Linear-GitHub Sync
Milestone

Comments

@altmannmarcelo
Copy link
Contributor

Description

Currently we have a command SHOW READYSET STATUS that displays some information about the status:

readyset> SHOW READYSET STATUS;
+----------------------------+--------------------------------------+
| Variable_name              | Value                                |
+----------------------------+--------------------------------------+
| Database Connection        | Connected                            |
| Connection Count           | 76                                   |
| Snapshot Status            | Completed                            |
| Maximum Replication Offset | mysql-bin-changelog.089135:126772593 |
| Minimum Replication Offset | mysql-bin-changelog.089135:126611220 |
| Last started Controller    | 2024-08-15 15:49:50 UTC              |
| Last completed snapshot    | 2024-08-15 15:51:30 UTC              |
| Last started replication   | 2024-08-15 15:51:30 UTC              |
+----------------------------+--------------------------------------+
8 rows in set (0.00 sec)

We also have an entire module dedicated to metrics status, but those are only available via http endpoint, which export the metrics using prometheus. In order to make it easier for external integration/monitoring tools to consume this metrics, we should create a SQL command to expose the metrics.

Ideally we should allow for query expressions, to filter which metric we want to fetch in case we don't want all the metrics, something like SHOW READYSET METRICS WHERE metric = 'some_metric' or SHOW READYSET METRICS WHERE metric LIKE 'some_%'

Change in user-visible behavior

Requires documentation change

@altmannmarcelo altmannmarcelo added the Medium priority Created by Linear-GitHub Sync label Aug 29, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.40, v.41 Aug 29, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.41, v.42 Sep 9, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.42, v.43, v.44 Sep 16, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.44, v.45 Sep 30, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.45, v.46 Oct 7, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.46, v.47, v.48 Oct 14, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.48, v.49 Oct 28, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.49, v.50 Nov 4, 2024
@altmannmarcelo altmannmarcelo modified the milestones: v.50, v.51 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant