Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List.move #1037

Merged
merged 11 commits into from
Nov 16, 2022
Merged

List.move #1037

merged 11 commits into from
Nov 16, 2022

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Nov 15, 2022 •
edited
Loading

  • Use updated realm-core
  • Update bindings
  • Implement List.move
  • Add tests of List.move
  • Update CHANGELOG

Resolves: #794

@cla-bot cla-bot bot added the cla: yes label Nov 15, 2022
@coveralls
Copy link

coveralls commented Nov 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3481410876

  • 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.96%
Files with Coverage Reduction New Missed Lines %
lib/src/realm_class.dart 1 92.66%
lib/src/subscription.dart 1 90.48%
Totals Coverage Status
Change from base Build 3470585651: -0.01%
Covered Lines: 2764
Relevant Lines: 3107
💛 - Coveralls

@nielsenko nielsenko marked this pull request as ready for review November 15, 2022 12:28
@nielsenko nielsenko requested review from blagoev, nirinchev and desistefanova and removed request for blagoev and nirinchev November 15, 2022 12:28
desistefanova
desistefanova reviewed Nov 16, 2022
View reviewed changes
test/list_test.dart Show resolved Hide resolved
test/list_test.dart Show resolved Hide resolved
test/list_test.dart Show resolved Hide resolved
lib/src/list.dart Outdated Show resolved Hide resolved
lib/src/list.dart Show resolved Hide resolved
blagoev
blagoev suggested changes Nov 16, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
blagoev
blagoev suggested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@blagoev blagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wonder should we rename the parameters

lib/src/list.dart Show resolved Hide resolved
blagoev
blagoev reviewed Nov 16, 2022
View reviewed changes
lib/src/list.dart Outdated Show resolved Hide resolved
blagoev
blagoev reviewed Nov 16, 2022
View reviewed changes
lib/src/list.dart Outdated Show resolved Hide resolved
@nielsenko
Copy link
Contributor Author

just wonder should we rename the parameters

Use from/to consistently now.

@nielsenko nielsenko merged commit 64cde9f into master Nov 16, 2022
@nielsenko nielsenko deleted the kn/list-move branch November 16, 2022 17:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desistefanova desistefanova desistefanova approved these changes

@blagoev blagoev blagoev approved these changes

@nirinchev nirinchev nirinchev approved these changes

Assignees

@nielsenko nielsenko

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RealmList.move
5 participants
@nielsenko @coveralls @nirinchev @blagoev @desistefanova