Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cglm incorrectly assumes that SSE2 is also available when SSE1 is #401

Closed
aryalaadi opened this issue Mar 27, 2024 · 3 comments
Closed

cglm incorrectly assumes that SSE2 is also available when SSE1 is #401

aryalaadi opened this issue Mar 27, 2024 · 3 comments

Comments

@aryalaadi
Copy link

this causes builds for i686 to fail

related issue

@recp
Copy link
Owner

recp commented Mar 27, 2024

Hi @aryalaadi,

You are right we must check these separately. Actually most of existing operations are f32 which is supported by SSE. There are some exceptions like _mm_castsi128_ps and maybe more... We can check where SSE2 is not supported and fallback some intrinsics to SSE if possible.

Added to TODOs, but a PR would indeed bring the fix more quickly

@recp
Copy link
Owner

recp commented Mar 31, 2024

@aryalaadi I tried to fix the issue at #412 any help, feedbacks would be awesome to make the work bug-less

@recp recp linked a pull request Mar 31, 2024 that will close this issue
5 tasks
@recp recp removed a link to a pull request Mar 31, 2024
5 tasks
@recp
Copy link
Owner

recp commented Apr 1, 2024

The issue is fixed at v0.9.4: https://github.com/recp/cglm/releases

Thanks for reporting this.

@recp recp closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants