Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscribeHandler not working when NonVerbose is true #22

Closed
kevin96666 opened this issue Feb 13, 2020 · 3 comments
Closed

SubscribeHandler not working when NonVerbose is true #22

kevin96666 opened this issue Feb 13, 2020 · 3 comments
Labels
bug help wanted

Comments

@kevin96666
Copy link
Contributor

Hello,

I don't understand why the SubscribeHandler is executed only when getNonVerbose is false.
Is mean that we can't use this feature in NonVerbose mode. Makes no sense for me.
Is there any reason ?
@loeffel-io
Copy link
Member

Hey @kevin96666

You are absolutely right! The keepAlive system is also not working with the nonVerbose mode.
Would love to see a PR for this!

@loeffel-io loeffel-io added the bug label Feb 13, 2020
@kevin96666
Copy link
Contributor Author

Hey @loeffel-io

Just did a PR.

@loeffel-io loeffel-io mentioned this issue Feb 13, 2020
Merged
@loeffel-io
Copy link
Member

Thanks @kevin96666

Now available in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevin96666 @loeffel-io