Collide less with occluded faces. Fixes #221. #731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qreeves
reviewed
Sep 30, 2017
src/engine/octa.h
Outdated
| @@ -339,3 +339,4 @@ enum | |||
| GENFACEVERTSXY(x0,x1, y0,y1, z0,z1, c0,c1, r0,r1, d0,d1) \ | |||
| GENFACEVERTSZ(x0,x1, y0,y1, z0,z1, c0,c1, r0,r1, d0,d1) | |||
|
|
|||
| bool collidesolidface(const cube &c, const int orient, const ivec &co, const int size); | |||
There was a problem hiding this comment.
Is it a code style thing? Otherwise there's no difference AFAIK.
There was a problem hiding this comment.
It's a linker thing, extern explicitly makes the function explicitly public. Even if it doesn't make an explicit difference linking the Red Eclipse binaries, it is more explicit to put extern there. So, yes, a code style thing.
There was a problem hiding this comment.
Top level functions have external linkage by default, so it makes no difference. It seems to be a convention in Cube 2 to mark them explicitly extern in header files.
…ind clip). Mark collidesolidface as extern (code style).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the #221 comes from engine checking for collision surfaces that are occluded by it's neighbours. While in theory it doesn't seem feasable to eliminate all such cases, the combination of excluding fully occluded surfaces from collision detection and increasing rounding error margin fixes all the cases I've been able to find or construct.