diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index d17bbf1..a474af1 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -41,16 +41,16 @@ jobs: tags: latest,${{ steps.get_version.outputs.VERSION }} push: ${{ startsWith(github.ref, 'refs/tags/') }} # On tag, Pack zip of scuttle for GitHub Release - # - name: Pack - # run: | - # mkdir build/artifacts - # zip -r -j build/artifacts/scuttle-linux-amd64.zip build/linux/amd64/ - # if: startsWith(github.ref, 'refs/tags/') + - name: Pack + run: | + mkdir build/artifacts + zip -r -j build/artifacts/scuttle-linux-amd64.zip build/linux/amd64/ + if: startsWith(github.ref, 'refs/tags/') # On tag, Create GitHub Release - # - name: Release - # uses: softprops/action-gh-release@v1 - # if: startsWith(github.ref, 'refs/tags/') - # with: - # files: build/artifacts/*.zip - # env: - # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file + - name: Release + uses: softprops/action-gh-release@v1 + if: startsWith(github.ref, 'refs/tags/') + with: + files: build/artifacts/*.zip + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file diff --git a/README.md b/README.md index be8fac1..9a27d4a 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Scuttle -`scuttle` Is a wrapper application that makes it easy to run containers next to Istio sidecars. It ensures the main application doesn't start until envoy is ready, and that the istio sidecar shuts down when the application exists. This particularly useful for Jobs that need Istio sidecar injection, as the Istio pod would otherwise run indefinitely after the job is completed. +`scuttle` Is a wrapper application that makes it easy to run containers next to Istio sidecars. It ensures the main application doesn't start until envoy is ready, and that the istio sidecar shuts down when the application exits. This particularly useful for Jobs that need Istio sidecar injection, as the Istio pod would otherwise run indefinitely after the job is completed. This application, if provided an `ENVOY_ADMIN_API` environment variable, will poll indefinitely with backoff, waiting for envoy to report itself as live, implying it has loaded cluster configuration (for example from an ADS server). Only then will it execute the command provided as an argument. @@ -50,7 +50,7 @@ To enable this, you must add `shareProcessNamespace: true` to your **Pod** defin ```dockerfile FROM python:latest # Below command makes scuttle available in path -COPY --from=jacobsvante/scuttle:latest /scuttle /bin/scuttle +COPY --from=redboxoss/scuttle:latest /scuttle /bin/scuttle WORKDIR /app COPY /app/ ./ ENTRYPOINT ["scuttle", "python", "-m", "my_app"]