{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":219598318,"defaultBranch":"master","name":"baseplate.go","ownerLogin":"reddit","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-11-04T21:16:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/14248?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727213241.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"c466e4e9a9ebb5855eb036d4116c5ffbc95b7074","ref":"refs/heads/remove-tracing-default-middlewares","pushedAt":"2024-09-24T21:27:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"thriftbp/httpbp: Remove tracing from default middlewares\n\nServers/clients should manually add v2 tracing middlewares if needed, or\nswitch to v2 servers/clients.","shortMessageHtmlLink":"thriftbp/httpbp: Remove tracing from default middlewares"}},{"before":"86ce8d63e8fe8120aa1ea1786db7ec3fc0c27ab1","after":"c7e065837fc5906607a660629fb6f9cb08e3247d","ref":"refs/heads/master","pushedAt":"2024-09-24T17:28:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Update thrift to v0.21.0\n\nAlso rerun thrift compiler v0.21.0 on baseplate.thrift.\n\nAlso add thriftbp.ClientPoolConfig.UseZlib, which was not possible\nbefore.","shortMessageHtmlLink":"Update thrift to v0.21.0"}},{"before":"54cbc95ff639e7dd0ec61991fe26a431f48decce","after":null,"ref":"refs/heads/kafkabp-zone-id-rack","pushedAt":"2024-09-23T15:40:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"6a67aa706e83d611e218d95307a5b20b87fd256d","after":"86ce8d63e8fe8120aa1ea1786db7ec3fc0c27ab1","ref":"refs/heads/master","pushedAt":"2024-09-23T15:40:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"kafkabp: Add AWSAvailabilityZoneIDRackID rack implementation","shortMessageHtmlLink":"kafkabp: Add AWSAvailabilityZoneIDRackID rack implementation"}},{"before":null,"after":"54cbc95ff639e7dd0ec61991fe26a431f48decce","ref":"refs/heads/kafkabp-zone-id-rack","pushedAt":"2024-09-20T18:47:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"kafkabp: Add AWSAvailabilityZoneIDRackID rack implementation","shortMessageHtmlLink":"kafkabp: Add AWSAvailabilityZoneIDRackID rack implementation"}},{"before":"febde9a670153f043924d307ade9cee8ef803f31","after":"6a67aa706e83d611e218d95307a5b20b87fd256d","ref":"refs/heads/master","pushedAt":"2024-09-09T15:06:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"justinmir","name":"Justin","path":"/justinmir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8886628?s=80&v=4"},"commit":{"message":"Support attributing client metrics back to the owning cluster (#661)\n\n* Support attributing client metrics back to the owning clusterj\r\n\r\nThis adds a new cluster label to client metrics. This can be used to\r\njoin the client metrics with the cluster metrics in the cluster\r\ndashboards.\r\n\r\nWe set the cluster label only if we can determine it from the address,\r\notherwise it remains an empty string.\r\n---------\r\n\r\nCo-authored-by: Justin Miron <justin.miron@reddit.com>","shortMessageHtmlLink":"Support attributing client metrics back to the owning cluster (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2511173035\" data-permission-text=\"Title is private\" data-url=\"https://github.com/reddit/baseplate.go/issues/661\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/reddit/baseplate.go/pull/661/hovercard\" href=\"https://github.com/reddit/baseplate.go/pull/661\">#661</a>)"}},{"before":"6c818f5ad9e3c2dbf812327df9abb735ef3a1f75","after":null,"ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T23:16:19.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"8264c73578d210ffab6d4fbb0a734271d0c79c40","after":"febde9a670153f043924d307ade9cee8ef803f31","ref":"refs/heads/master","pushedAt":"2024-08-15T23:16:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.\n\nAlso add `yaml:\"-\"` explicitly for config struct fields that's not\nyaml-unmarshal-able.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"a6a43827b0a16ecf9d529aa877e0d7f5070fac9c","after":"6c818f5ad9e3c2dbf812327df9abb735ef3a1f75","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T23:07:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.\n\nAlso add `yaml:\"-\"` explicitly for config struct fields that's not\nyaml-unmarshal-able.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"01609be9bf73f1fc63bd225417a39e6fdea779ec","after":"a6a43827b0a16ecf9d529aa877e0d7f5070fac9c","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T23:06:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.\n\nAlso add `yaml:\"-\"` explicitly for config struct fields that's not\nyaml-unmarshaled.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"a2c7e9e781b30f6331c8fb97e91f431dc47cf2be","after":"01609be9bf73f1fc63bd225417a39e6fdea779ec","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T22:51:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Fixup: Add test for log.Wrapper.MarshalYAML","shortMessageHtmlLink":"Fixup: Add test for log.Wrapper.MarshalYAML"}},{"before":"cfb81f715e80a774b718f6f438fb8dd6a8a90fdc","after":"a2c7e9e781b30f6331c8fb97e91f431dc47cf2be","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T22:50:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Fixup: Add test for log.Wrapper.MarshalYAML","shortMessageHtmlLink":"Fixup: Add test for log.Wrapper.MarshalYAML"}},{"before":"95c61de6beacf5e4b466551044f660b34648d436","after":"cfb81f715e80a774b718f6f438fb8dd6a8a90fdc","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T20:35:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.\n\nAlso add `yaml:\"-\"` explicitly for config struct fields that's not\nyaml-unmarshaled.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"2bed71ddd2b8c93c2fc6666af880e8af7c2f76b6","after":null,"ref":"refs/heads/update-go-versions","pushedAt":"2024-08-15T20:35:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"63f8545a4c58dbb0ac0bf29df54e782066410206","after":"8264c73578d210ffab6d4fbb0a734271d0c79c40","ref":"refs/heads/master","pushedAt":"2024-08-15T20:35:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Update supported go versions to 1.22+1.23","shortMessageHtmlLink":"Update supported go versions to 1.22+1.23"}},{"before":"4f0d3508f737dc01609698887508261c4caa82fb","after":"95c61de6beacf5e4b466551044f660b34648d436","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T17:48:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.\n\nAlso add `yaml:\"-\"` explicitly for config struct fields that's not\nyaml-unmarshaled.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"5989dd526c3b93d7688767d01369997489664251","after":"4f0d3508f737dc01609698887508261c4caa82fb","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T17:46:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.\n\nAlso add `yaml:\"-\"` explicitly for config struct fields that cannot be\nyaml-unmarshaled.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"5b8d761aeebce3eaa73b3703b3370ffe0aca5652","after":"5989dd526c3b93d7688767d01369997489664251","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T17:13:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields\n\nAlso implement log.Wrapper.MarshalYAML for nil values.","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"16fe0ae7ee879e9e619436573b592433b6477026","after":"2bed71ddd2b8c93c2fc6666af880e8af7c2f76b6","ref":"refs/heads/update-go-versions","pushedAt":"2024-08-15T16:26:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Update supported go versions to 1.22+1.23","shortMessageHtmlLink":"Update supported go versions to 1.22+1.23"}},{"before":null,"after":"16fe0ae7ee879e9e619436573b592433b6477026","ref":"refs/heads/update-go-versions","pushedAt":"2024-08-15T16:23:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Update supported go versions to 1.22+1.23","shortMessageHtmlLink":"Update supported go versions to 1.22+1.23"}},{"before":null,"after":"5b8d761aeebce3eaa73b3703b3370ffe0aca5652","ref":"refs/heads/omit-empty-deprecated-log-wrapper","pushedAt":"2024-08-15T16:14:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"Add omitempty yaml tag to deprecated log.Wrapper fields","shortMessageHtmlLink":"Add omitempty yaml tag to deprecated log.Wrapper fields"}},{"before":"b7dafe21f531f88b819628e1c4de3a3e36208887","after":"63f8545a4c58dbb0ac0bf29df54e782066410206","ref":"refs/heads/master","pushedAt":"2024-06-11T18:59:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"kafkabp: Support AWS IMDS v2 for rack id\n\nAlso modernize the code a bit (use sync.OnceValues, etc.).","shortMessageHtmlLink":"kafkabp: Support AWS IMDS v2 for rack id"}},{"before":"8e882273f50250a11a43d4badaeec23f65e97fa9","after":null,"ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T20:23:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"2a4cb03283d3173da9fc274c995e65337a693264","after":"b7dafe21f531f88b819628e1c4de3a3e36208887","ref":"refs/heads/master","pushedAt":"2024-05-24T20:23:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":"eec80c87afbb4689616d544b346dc996f9693be6","after":"8e882273f50250a11a43d4badaeec23f65e97fa9","ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T18:37:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":"e85e3cddf0b3e11d28f5b767f5fcaacaa26e2410","after":"eec80c87afbb4689616d544b346dc996f9693be6","ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T18:36:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":null,"after":"e85e3cddf0b3e11d28f5b767f5fcaacaa26e2410","ref":"refs/heads/clientpool-get-after-close-error","pushedAt":"2024-05-24T18:31:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"clientpool: Check Get after Close and return appropriate error\n\nCurrently, when Get is Called after Close, we'll just get a nil client\nfrom the pool and the next `c.IsOpen` check will just panic, which makes\nit very hard to debug why. Add a check to return an appropriate error.","shortMessageHtmlLink":"clientpool: Check Get after Close and return appropriate error"}},{"before":"d04f7ff29242fde8123e2484c9b51a2f4adcf928","after":null,"ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T17:45:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"}},{"before":"622dd70750cc1b64e561958af4c8a23f43e8878b","after":"2a4cb03283d3173da9fc274c995e65337a693264","ref":"refs/heads/master","pushedAt":"2024-05-24T17:45:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}},{"before":"f0e1ee2dc3fbb65ede0b6ee79326769d2265f01e","after":"d04f7ff29242fde8123e2484c9b51a2f4adcf928","ref":"refs/heads/filewatcher-v2-users","pushedAt":"2024-05-24T17:39:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"fishy","name":"Yuxuan 'fishy' Wang","path":"/fishy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78183?s=80&v=4"},"commit":{"message":"experiments: Switch to filewatcher/v2\n\nNote: secrets package is not switching because\nfilewatcher.MockFileWatcher is part of its API so switching to v2 will\nbe a breaking change for secrets package.","shortMessageHtmlLink":"experiments: Switch to filewatcher/v2"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNFQyMToyNzoyMS4wMDAwMDBazwAAAAS_pI_y","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNS0yNFQxNzozOTozOS4wMDAwMDBazwAAAARTR2RB"}},"title":"Activity · reddit/baseplate.go"}