Don't fail to finalize observers if one fails (#811)

reddit · Oct 25, 2023 · 8c44633 · 8c44633
1 parent 1142489
commit 8c44633
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/baseplate/__init__.py b/baseplate/__init__.py
@@ -629,7 +629,10 @@ def finish(self, exc_info: Optional[_ExcInfo] = None) -> None:
 
         """
         for observer in self.observers:
-            observer.on_finish(exc_info)
+            try:
+                observer.on_finish(exc_info)
+            except Exception:
+                logger.exception("Exception raised while finalizing observer")
 
         # clean up reference cycles
         self.context = None  # type: ignore