comments

reddit · Nov 30, 2023 · d16b210 · d16b210
1 parent aa0eff1
commit d16b210
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/baseplate/sidecars/live_data_watcher.py b/baseplate/sidecars/live_data_watcher.py
@@ -125,8 +125,8 @@ def _load_from_s3(data: bytes) -> bytes:
     try:
         num_file_shards = loader_config.get("num_file_shards")
 
-        # We can't assume that every caller of this method will be using prefix sharding on
-        # their S3 objects (but at least one service definitely does - experiments).
+        # We can't assume that every ZK Node that is being NodeWatched by the live-data-fetcher
+        # will make use of S3 prefix sharding - but, we know at least one does (/experiments).
         # If it's not present or the value is 1, set the prefix to empty string ""
         if not num_file_shards or num_file_shards == 1:
             sharded_file_key_prefix = ""