From d16b2105ff9f20688fb58ebe3a807a07f592e13f Mon Sep 17 00:00:00 2001 From: Siddharth Manoj Date: Thu, 30 Nov 2023 10:29:23 -0500 Subject: [PATCH] comments --- baseplate/sidecars/live_data_watcher.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/baseplate/sidecars/live_data_watcher.py b/baseplate/sidecars/live_data_watcher.py index 73ee22f43..6f7fd11b9 100644 --- a/baseplate/sidecars/live_data_watcher.py +++ b/baseplate/sidecars/live_data_watcher.py @@ -125,8 +125,8 @@ def _load_from_s3(data: bytes) -> bytes: try: num_file_shards = loader_config.get("num_file_shards") - # We can't assume that every caller of this method will be using prefix sharding on - # their S3 objects (but at least one service definitely does - experiments). + # We can't assume that every ZK Node that is being NodeWatched by the live-data-fetcher + # will make use of S3 prefix sharding - but, we know at least one does (/experiments). # If it's not present or the value is 1, set the prefix to empty string "" if not num_file_shards or num_file_shards == 1: sharded_file_key_prefix = ""