Upgrade to Thrift 0.19.0 #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckw4ng
commented
Sep 21, 2023
requirements-transitive.txt
Outdated
| @@ -79,7 +79,7 @@ sphinxcontrib-jsmath==1.0.1 | |||
| sphinxcontrib-qthelp==1.0.3 | |||
| sphinxcontrib-serializinghtml==1.1.4 | |||
| SQLAlchemy==1.4.12 | |||
| thrift==0.14.1 | |||
| thrift @ git+https://github.com/apache/[email protected]#egg=thrift&subdirectory=lib/py | |||
There was a problem hiding this comment.
If we cannot get the Thrift maintainers to upload a release to PyPI, we will need to use thrift-unofficial under our control to set up a release there, or rely on this specific github install directive.
KTAtkinson
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Use the latest Thrift 0.19.0 library and compiler as dependencies.
📜 Details
Thrift 0.19.0 has at least one compatibility update for Baseplate to work in Python 3.11. Upgrade the dependency chain and included Thrift definitions to use Thrift 0.19.0. The primary update is at these lines
🧪 Testing Steps / Validation
✅ Checks