Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Telemetry #819

Merged
merged 45 commits into from
Jul 23, 2024
Merged

Open Telemetry #819

merged 45 commits into from
Jul 23, 2024

Commits on May 6, 2024

  1. feat: adhoc: Update pre-commit hooks and Dockerfile for local dev

    Xaelias authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3906dd1 View commit details
    Browse the repository at this point in the history
  2. feat: adhoc: Install opentelemetry pacakges, create Reddit trace prop…

    …agator and log trace IDs
    Xaelias authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c89b58e View commit details
    Browse the repository at this point in the history
  3. feat: adhoc: Implement opentelemetry for thrift client and server

    Xaelias authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8875362 View commit details
    Browse the repository at this point in the history
  4. feat: adhoc: Instrument pyramid/request with Opentelemetry

    Xaelias authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ca26600 View commit details
    Browse the repository at this point in the history
  5. trying to move the auto instrumentation around as requested

    Xaelias authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3603ce0 View commit details
    Browse the repository at this point in the history
  6. Addressed some PR comments

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    82405bc View commit details
    Browse the repository at this point in the history
  7. Change these back from BaseException to Exception

    I think we are fine here since we re-raise the exception anyways, if you miss ending a span for exceptions that are not included in  I think that is OK.
    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3ccd636 View commit details
    Browse the repository at this point in the history
  8. Switch thrift back to and record the exception to otel.

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    46459d9 View commit details
    Browse the repository at this point in the history
  9. Don't explicitly record the exception as we enabled the auto exceptio…

    …n recording option when creating the span
    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    1213039 View commit details
    Browse the repository at this point in the history
  10. Update propagator to correctly follow baseplate spec using base10 int…

    …egers
    
    This also shifts to the assumption that we do not truncate the 128 bit trace id but send it as is.
    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2382d2e View commit details
    Browse the repository at this point in the history
  11. Apply linting fixes

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    448ae17 View commit details
    Browse the repository at this point in the history
  12. fix

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ee175eb View commit details
    Browse the repository at this point in the history
  13. Fix pyramid tests to reflect the baseplate spec's use of base10 trace…

    …/span ids.
    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    40f8688 View commit details
    Browse the repository at this point in the history
  14. Update how we configure propagators so that we support the different …

    …headers between thrift and http
    
    The difference here is that our HTTP headers have the 'X-' prefix and Thrift does not according to the baseplate spec.
    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    fefd6d2 View commit details
    Browse the repository at this point in the history
  15. Fix formatting and linting

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    16202e6 View commit details
    Browse the repository at this point in the history
  16. regex fix

    Co-authored-by: Chris Kuehl <[email protected]>
    2 people authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    2410d6b View commit details
    Browse the repository at this point in the history
  17. regex fix x2

    Co-authored-by: Chris Kuehl <[email protected]>
    2 people authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3f56f61 View commit details
    Browse the repository at this point in the history
  18. Simplify conditional logic in server init

    Co-authored-by: Chris Kuehl <[email protected]>
    2 people authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3d7ef32 View commit details
    Browse the repository at this point in the history
  19. Move instrumentation back to modules instead of __init__ (#846)

    Co-authored-by: Trevor Riles <[email protected]>
    trevorriles and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0825a6e View commit details
    Browse the repository at this point in the history
  20. Trevorriles/temp (#910)

    Add support for thrift header propagation.
    trevorriles authored and Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    de5f9ee View commit details
    Browse the repository at this point in the history
  21. Rebase fixes

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    42fcdf0 View commit details
    Browse the repository at this point in the history
  22. Update cached_property wrapper

    This change is based on the upstream pyramid reify code we orginally lifted this from.
    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3905041 View commit details
    Browse the repository at this point in the history
  23. Add back in baseplate thrift errorcode fix

    Trevor Riles committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a5c750a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Fix indentation error made during rebase

    Trevor Riles committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f194423 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f35abeb View commit details
    Browse the repository at this point in the history
  3. Fix mypy type that was missed during rebase

    Trevor Riles committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4ca3656 View commit details
    Browse the repository at this point in the history
  4. Remove reset_metrics method in tests that did not call it

    Trevor Riles committed May 16, 2024
    Configuration menu
    Copy the full SHA
    62c8347 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Move baseplate.py sampling and configuration to be more in line with … (

    #920)
    
    * Move baseplate.py sampling and configuration to be more in line with baseplate.go implementation
    
    ---------
    
    Co-authored-by: Trevor Riles <[email protected]>
    trevorriles and Trevor Riles committed May 31, 2024
    Configuration menu
    Copy the full SHA
    5216cfe View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Merge branch 'develop' of github.com:reddit/baseplate.py into aleksei…

    ….lesieur/opentelemetry2
    Trevor Riles committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7969d5a View commit details
    Browse the repository at this point in the history
  2. make fmt

    Trevor Riles committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9834885 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Update baseplate/frameworks/thrift/__init__.py

    Co-authored-by: redloaf <[email protected]>
    trevorriles and redloaf committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e478766 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Bump lxml from 5.2.1 to 5.2.2 (#921)

    Bumps [lxml](https://github.com/lxml/lxml) from 5.2.1 to 5.2.2.
    - [Release notes](https://github.com/lxml/lxml/releases)
    - [Changelog](https://github.com/lxml/lxml/blob/master/CHANGES.txt)
    - [Commits](lxml/lxml@lxml-5.2.1...lxml-5.2.2)
    
    ---
    updated-dependencies:
    - dependency-name: lxml
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    90206a1 View commit details
    Browse the repository at this point in the history
  2. Bump boto3 from 1.34.95 to 1.34.117 (#922)

    Bumps [boto3](https://github.com/boto/boto3) from 1.34.95 to 1.34.117.
    - [Release notes](https://github.com/boto/boto3/releases)
    - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
    - [Commits](boto/boto3@1.34.95...1.34.117)
    
    ---
    updated-dependencies:
    - dependency-name: boto3
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ca45736 View commit details
    Browse the repository at this point in the history
  3. Bump actions/checkout from 4.1.4 to 4.1.6 (#927)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.6.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@0ad4b8f...a5ac7e5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    010118e View commit details
    Browse the repository at this point in the history
  4. v2.7.0

    chriskuehl authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4b9af5d View commit details
    Browse the repository at this point in the history
  5. Bump urllib3 from 1.26.18 to 1.26.19 (#931)

    Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.18 to 1.26.19.
    - [Release notes](https://github.com/urllib3/urllib3/releases)
    - [Changelog](https://github.com/urllib3/urllib3/blob/1.26.19/CHANGES.rst)
    - [Commits](urllib3/urllib3@1.26.18...1.26.19)
    
    ---
    updated-dependencies:
    - dependency-name: urllib3
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6ab0c0c View commit details
    Browse the repository at this point in the history
  6. Bump typing-extensions from 4.12.0 to 4.12.2 (#939)

    Bumps [typing-extensions](https://github.com/python/typing_extensions) from 4.12.0 to 4.12.2.
    - [Release notes](https://github.com/python/typing_extensions/releases)
    - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md)
    - [Commits](python/typing_extensions@4.12.0...4.12.2)
    
    ---
    updated-dependencies:
    - dependency-name: typing-extensions
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fbe77fd View commit details
    Browse the repository at this point in the history
  7. Bump moto from 5.0.9 to 5.0.10 (#938)

    Bumps [moto](https://github.com/getmoto/moto) from 5.0.9 to 5.0.10.
    - [Release notes](https://github.com/getmoto/moto/releases)
    - [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md)
    - [Commits](getmoto/moto@5.0.9...5.0.10)
    
    ---
    updated-dependencies:
    - dependency-name: moto
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5dd625a View commit details
    Browse the repository at this point in the history
  8. Bump pylint from 3.2.2 to 3.2.5 (#937)

    Bumps [pylint](https://github.com/pylint-dev/pylint) from 3.2.2 to 3.2.5.
    - [Release notes](https://github.com/pylint-dev/pylint/releases)
    - [Commits](pylint-dev/pylint@v3.2.2...v3.2.5)
    
    ---
    updated-dependencies:
    - dependency-name: pylint
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    853fe62 View commit details
    Browse the repository at this point in the history
  9. Bump flake8 from 7.0.0 to 7.1.0 (#936)

    Bumps [flake8](https://github.com/pycqa/flake8) from 7.0.0 to 7.1.0.
    - [Commits](PyCQA/flake8@7.0.0...7.1.0)
    
    ---
    updated-dependencies:
    - dependency-name: flake8
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e03785d View commit details
    Browse the repository at this point in the history
  10. Bump types-setuptools from 70.0.0.20240524 to 70.1.0.20240627 (#935)

    Bumps [types-setuptools](https://github.com/python/typeshed) from 70.0.0.20240524 to 70.1.0.20240627.
    - [Commits](https://github.com/python/typeshed/commits)
    
    ---
    updated-dependencies:
    - dependency-name: types-setuptools
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3a5858a View commit details
    Browse the repository at this point in the history
  11. Bump boto3 from 1.34.117 to 1.34.136 (#932)

    Bumps [boto3](https://github.com/boto/boto3) from 1.34.117 to 1.34.136.
    - [Release notes](https://github.com/boto/boto3/releases)
    - [Commits](boto/boto3@1.34.117...1.34.136)
    
    ---
    updated-dependencies:
    - dependency-name: boto3
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f2301a9 View commit details
    Browse the repository at this point in the history
  12. Bump certifi from 2024.2.2 to 2024.7.4 (#944)

    Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4.
    - [Commits](certifi/python-certifi@2024.02.02...2024.07.04)
    
    ---
    updated-dependencies:
    - dependency-name: certifi
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored and Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1aa4252 View commit details
    Browse the repository at this point in the history
  13. Remove broken environment variable based configuration. Sampling conf…

    …ig will come with a future release keeping us aligned with baseplate.go v2
    Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b925e67 View commit details
    Browse the repository at this point in the history
  14. Remove unused imports

    Trevor Riles committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cf426c7 View commit details
    Browse the repository at this point in the history