Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold license header by default #89

Open
1 task done
akurtakov opened this issue Aug 9, 2023 · 2 comments
Open
1 task done

Fold license header by default #89

akurtakov opened this issue Aug 9, 2023 · 2 comments
Labels
enhancement New feature or request upstream-lsp4e

Comments

@akurtakov
Copy link
Collaborator

Suggestion

License header is not the first thing one wants to check when opening java file.
JDT-LS returns a list of folding ranges that can have a kind of "comment" or "imports" or "region" so folding "comments" when this comment range starts on first line should do the trick.

Community

  • I understand suggesting an enhancement doesn't mandate anyone to implement it. Other contributors may consider this suggestion, or not, at their own convenience. The most efficient way to get it fixed is that I implement it myself and contribute it back as a good quality patch to the project.
@akurtakov akurtakov added the enhancement New feature or request label Aug 9, 2023
@mickaelistria
Copy link
Collaborator

As we wouldn't want to collapse all comments block by default, we'll need the LS to inform about the block being legal. I suggested microsoft/language-server-protocol#1819 to add such possibility in the spec.

@mickaelistria
Copy link
Collaborator

As discussed on microsoft/language-server-protocol#1819 , this would better be implemented on cliend side (LSP4E) here, processing comments block and deciding whether to collapse them or not according to content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream-lsp4e
Projects
None yet
Development

No branches or pull requests

2 participants