Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dedicatedPod field on container components #6786

Open
rm3l opened this issue May 3, 2023 · 4 comments
Open

Support dedicatedPod field on container components #6786

rm3l opened this issue May 3, 2023 · 4 comments
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.

Comments

@rm3l
Copy link
Member

rm3l commented May 3, 2023

/kind feature
/area devfile-spec

Which functionality do you think we should add?

dedicatedPod seems to be ignored currently by odo. Per the Devfile spec, it is supposed to allow running a container in its own Pod.

This seems to be a limitation in the Devfile library: devfile/api#670. So I guess it must be fixed in the library, then pulled into odo.

Why is this needed?

To improve our coverage of the Devfile spec

I guess supporting this might have other implications like:

  • port-forwarding: make sure to port-forward to the right pod
  • Limitations on unique port values might no longer make sense in some cases, e.g., having the same port defined in different container components is okay, as long as they are in different pods.
  • Impact on Podman
  • ...

Related

@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels May 3, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label May 3, 2023
@rm3l rm3l added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jun 1, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 1, 2023

Grooming (2023-06-01)

Check if it is supported in DevSpaces (1 story point for researching).
Priority will depend on whether it is supported there or not. If it is, we'll consider supporting it here as well (we'll groom it later on). But if it is not, we'll lower the priority, unless someone really needs this.

@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jun 13, 2023
@feloy
Copy link
Contributor

feloy commented Jun 15, 2023

dedicatedPod is not supported in DevSpaces.
Tested with project https://github.com/feloy/devspaces-demo

devspaces-dedicatedpod

dedicated-pod

@feloy feloy moved this to In Review 👀 in odo Project Jun 15, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 15, 2023

/priority Low

@openshift-ci openshift-ci bot added the priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done. label Jun 15, 2023
@rm3l rm3l moved this from In Review 👀 to Done ✅ in odo Project Jun 15, 2023
@rm3l
Copy link
Member Author

rm3l commented Jun 15, 2023

dedicatedPod is not supported in DevSpaces. Tested with project feloy/devspaces-demo

devspaces-dedicatedpod

dedicated-pod

Thanks for the research, @feloy! Based on that information, I've reduced the priority of this issue and will add it for future grooming consideration if we decide to work on it later.

/lifecycle frozen

@openshift-ci openshift-ci bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jun 15, 2023
@rm3l rm3l added epic/5834-spec and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Jun 15, 2023
@rm3l rm3l removed the status in odo Project Jun 27, 2023
@rm3l rm3l unassigned feloy Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/Low Nice to have issue. It's not immediately on the project roadmap to get it done.
Projects
Status: No status
Development

No branches or pull requests

2 participants