-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows editing of start/end tag simultaneously #204
Allows editing of start/end tag simultaneously #204
Conversation
Can't get it to work. Output filled with errors like:
|
c19e05d
to
339ce59
Compare
@fbricon I can't recreate this, but maybe it is using the bugged version of the code. I pushed the new one here, just pull the client again and hopefully this disappears. |
Works beautifully now, can't reproduce the issue from earlier. That's a great feature, nice job @NikolasKomonen! |
Spoke too soon, I can still reproduce. add space at the end of a tag, delete, rinse, repeat until the exception shows up |
definitely reminds me of #149. We prolly need to make the server side more robust wrt cancelled commands |
I think the key here is "rejected promise not handled within 1 second". Server is too slow to respond, then client cancels the request. |
See https://stackoverflow.com/a/50124430/753170 for a potential solution |
339ce59
to
2be9253
Compare
Yup, this worked for me. |
No this doesn't work for me |
Now that've been playing with it, I think we need a new command to toggle the preference, so that, when bound to a keystroke, you can enter/exit quick tag edit mode Also, the readme needs to be updated with the preference key (and documenting that new toggle command would help too) |
Right now you can press Esc to stop the edit mode. Is that good enough? Also, I have the README updated here in the PR here: https://github.com/redhat-developer/vscode-xml/pull/206/files#diff-04c6e90faac2675aa89e2176d2eec7d8R82 |
2be9253
to
4291bb6
Compare
Ctrl+Shift+F2 on linux/windows, Cmd+Shift+F2 on mac, to toggle matching tag editing |
16e72e6
to
25e4b93
Compare
Under the preference xml.autoSelectingMatchingTags Fixes redhat-developer#130 Signed-off-by: Nikolas Komonen <[email protected]>
25e4b93
to
f355a2c
Compare
@fbricon updated everything. The console error should be gone, cmd+shift+f2 should toggle the preference on your machine and a message should appear. |
please update the readme |
on configuration change, toggling the new pref should add/remove the mirror cursor immediately |
@@ -192,6 +192,12 @@ | |||
"description": "Enable/disable autoclosing of XML tags. \n\nIMPORTANT: Turn off editor.autoClosingTags for this to work", | |||
"scope": "window" | |||
}, | |||
"xml.matchingTagEditing": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about using the same name than vscode mirrorCursorOnMatchingTag
?
I implemented that here: https://github.com/xorye/vscode-xml/tree/matchingTagClient |
superseded by #207 |
Under the preference xml.autoSelectingMatchingTags
Fixes #130
Signed-off-by: Nikolas Komonen [email protected]