-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with npm run build-server on Windows #86
Comments
It isn't a problem.
mvnw.cmd can't download maven-wrapper.jar because some Windows versions have TLS 1.2 disabled. The Java LS (https://github.com/eclipse/eclipse.jdt.ls) has the same issue. We can do the following: a) enable TLS 1.2 on Windows as described at https://success.outsystems.com/Support/Enterprise_Customers/Maintenance_and_Operations/(.NET)_Enable_SSL_Protocols_for_your_Integrations_-_TLS_1.1_and_TLS_1.2 or b) add maven-wrapper.jar to the lsp4xml and eclipse.jdt.ls repository
All the projects including org.eclipse.lsp4xml.extensions.emmet build on both, Linux and Windows. |
Thanks @snjeza. I've added the maven wrapper to the lsp4xml git repo. @ralfhandl please try again. |
@snjeza can you confirm this works now on windows? |
I confirm. There is the same issue in vscode-java. |
When trying to build vscode-xml on Windows 10 Enterprise 1803 I run into a few issues:
npm install
ends with warningsnpm run build-server
ends with an error:maven-wrapper.jar
I ran into another maven-related error so I decided to look over at https://github.com/angelozerr/lsp4xml where I found the hint to./mvnw clean verify
(OSX, Linux) ormvnw.cmd clean verify
(Windows)Doing that gave me another bunch of errors:
vscode-xml
and re-rannpm run build-server
which then succeeded.So apparently just some steps are missing in CONTRIBUTING.md:
cd ../lsp4xml
./mvnw clean verify
(OSX, Linux) ormvnw.cmd clean verify
(Windows)cd ../vscode-xml
Plus the advice to ignore certain warnings or errors 😃
The text was updated successfully, but these errors were encountered: