Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 14 is EOL #928

Closed
datho7561 opened this issue Aug 24, 2023 · 3 comments · Fixed by #948
Closed

Node 14 is EOL #928

datho7561 opened this issue Aug 24, 2023 · 3 comments · Fixed by #948
Assignees
@rgrunber
Labels
debt dependencies Pull requests that update a dependency file
Milestone
0.27.0

Comments

@datho7561
Copy link
Contributor

Node 16 will also be EOL (no maintenance) on September 11 2023. As a result, we should upgrade to Node 18.

A part of this migration is updating the version of npm used and updating package-lock.json. npm v7, which ships with Node 16, changed the format of this file. This might cause some complications with npm-force-resolutions, which is a library we use to for all instances of a library to a specified version in the lockfile.
@datho7561 datho7561 added debt dependencies Pull requests that update a dependency file labels Aug 24, 2023
@fbricon
Copy link
Collaborator

fbricon commented Aug 24, 2023

can't update to 18 before the embedded version in VS Code updates too. Currently at 16

@fbricon
Copy link
Collaborator

fbricon commented Aug 24, 2023

well insiders's on 18, so probably for next month

@datho7561
Copy link
Contributor Author

I don't expect we will do a new release before the next VS Code release, unless something urgent comes up

@rgrunber rgrunber mentioned this issue Nov 16, 2023
Merged
@datho7561 datho7561 added this to the 0.27.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

Labels
debt dependencies Pull requests that update a dependency file
Projects
IDE Cloudaptors
Archived in project
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Update to Node 18 rgrunber/vscode-xml
3 participants
@fbricon @rgrunber @datho7561