Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior on format #90

Closed
Vincz opened this issue Jun 12, 2018 · 12 comments
Closed

Strange behavior on format #90

Vincz opened this issue Jun 12, 2018 · 12 comments
Assignees

Comments

@Vincz
Copy link

Vincz commented Jun 12, 2018

Hi!
Since yesterday, when I format a YAML file on save, it add the following header

_uri: 'file:///<path_to_my_file>.yaml'
_languageId: yaml
_version: 642
_content: |
  <content_of_my_file>
_lineOffsets:
    - 0
    - 9
    - 19

Any idea?

@JPinkney JPinkney added the bug label Jun 12, 2018
@JPinkney JPinkney self-assigned this Jun 12, 2018
@vict0rsch
Copy link

Same here, version 0.0.13, vscode 1.24.0

@JPinkney
Copy link
Contributor

It most likely went wrong during this commit. I should have a fix+release in the next week.

@mikehanney
Copy link

Format document goes more wrong when the end of line format is CRLF compared to when it is LF. Just saying in case it helps troubleshoot.

@tizmagik
Copy link

tizmagik commented Jul 5, 2018

Just hit this today too, vscode 1.24.1

@JPinkney
Copy link
Contributor

JPinkney commented Jul 5, 2018

It will be fixed in the release Monday! (There will be completely new formatter that preserves comments)

@shawnhwei
Copy link

Any update on this?

@Southclaws
Copy link

I cloned the repo and built a .vsix to test, the formatted seems fixed in the latest commit! Just needs to be released to the marketplace, if there are no other issues of couse.

@JPinkney
Copy link
Contributor

Everything is fixed in master, just for some reason jenkins doesn't want to push the latest build to the marketplace and its taking a bit to find out why.

@shawnhwei
Copy link

Can we offer any help with the Jenkins issue? Would really like to get this fix on our machines.

@JPinkney
Copy link
Contributor

JPinkney commented Jul 23, 2018

You can try checking out this repository, then running npm install vsce -g then running vsce package on in the directory containing this repo and tell me if anything goes wrong (it works fine on both my computers). Unfortunately I'm not the one who approves the releases so it may take some time.

@JPinkney
Copy link
Contributor

Just released the newest version. Unfortunately I wasn't able to get the new formatter in but atleast this issue is now resolved.

@Southclaws
Copy link

I just saved a travis config and got some extremely odd and quite funny results:

Before save:

sudo: required
services:
  - docker
before_install:
  - "sudo dpkg --add-architecture i386"
  - "sudo apt-get install -qq --force-yes build-essential gcc-multilib g++-multilib > /dev/null"
addons:
  apt:
    packages:
      - docker-ce
language: go
jobs:
  include:
    - stage: test smallbits
      script:
        - go test -race -v -p 4 -coverprofile=coverage.txt ./versioning ./util ./download ./compiler
        - bash <(curl -s https://codecov.io/bash)
    - stage: test runtime
      script:
        - go test -race -v -p 4 -coverprofile=coverage.txt ./runtime
        - bash <(curl -s https://codecov.io/bash)
    - stage: test rook
      script:
        - go test -race -v -p 4 -coverprofile=coverage.txt -timeout=20m ./rook
        - bash <(curl -s https://codecov.io/bash)
    - stage: deploy
      if: branch =~ ^(v?(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)(?:-[\da-z-]+(?:\.[\da-z-]+)*)?(?:\+[\da-z-]+(?:\.[\da-z-]+)*)?)$
      script:
        - test -n "$TRAVIS_TAG"
        - echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin
        - if [ `uname -m` = x86_64 ]; then sudo apt-get install -qq --force-yes gcc-multilib > /dev/null; fi
        - sudo apt-get install -y build-essential rpm
        - gem install --no-ri --no-rdoc fpm
        - curl -sL https://git.io/goreleaser | bash
go:
  - "1.10"

After save:

sudo: required
?
  service
: - - dock
? r
  before_inst
: - ' - "sudo dpkg --add-architecture '
  - '  - "sudo apt-get install -qq --force-yes build-essential gcc-multilib g++-multilib > /dev'
ull":
  ns::
    t::
      -
        -
ocker-ce: la
guag:
  ? o
    jobs
  : - lude::     - stage: t
      llbits:
        - pt:
          - go test -race -v -p 4 -coverprofile=coverage.txt ./versioning ./util ./down
        - iler
          - bash <(curl -s https://
    - .io/b: h)
        - st
      st run:
        - script:
          - go test -race -v -p 4 -coverprofile=cov
        - /runtime
          - bash <(curl -s http
    - ecov.: /bash)
      age: t:
        -     script:
          - go test -race -v -p 4 -coverprofile=coverage.
        - t=20m ./rook
          - bash <(curl -s
    - /code: v.io/b
      :  stage: deploy
        if: branch =~ ^(v?(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)\.(?:0|[1-9]\d*)(?:-[\da-z-]+(?:\.[\da-z-]+)*)?(?:\+[\d
      ?:\.[\:
        - $
          script:
        -  -n "$TRAVIS_TAG"
          - echo "$DOCKER_PASSWORD" | docker login -u "$DOCK
        - " --password-stdin
          - if [ `uname -m` = x86_64 ]; then sudo apt-get install -qq --force-ye
        - lib > /dev/null; fi
          - sudo apt-get
        -  build-essential rpm
          - g
        - --no-ri --no-rdoc fpm
          - curl -sL
ht:
  - "it.i"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants