Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built in kubernetes support #307

Open
5 tasks
JPinkney opened this issue Aug 20, 2020 · 5 comments · May be fixed by #841
Open
5 tasks

Remove built in kubernetes support #307

JPinkney opened this issue Aug 20, 2020 · 5 comments · May be fixed by #841

Comments

@JPinkney
Copy link
Contributor

It's probably time that we start to deprecate the built-in Kubernetes support from the language server. Although it is useful, it really shouldn't be bundled with the extension and it creates issues that have to be specifically solved inside of the language server that don't really make sense in the context of a pure YAML language server.

E.g. #220, #211, #132, redhat-developer/vscode-yaml#153, redhat-developer/vscode-yaml#246.

These are the things that should be done:

@ibotty
Copy link

ibotty commented Nov 18, 2020

It would be great to document how to migrate to a post-kubernetes yaml-language-server without losing kubernetes integration.

@FranciscoKurpiel
Copy link

FranciscoKurpiel commented Dec 28, 2020

I hate to be negative, but Kubernetes integration is the reason why I'm using this language server.

EDIT: nevermind, I just found out I can provide the kubernetes schema url instead of Kubernetes on the configuration file. It was not clear to me before, since this fact is not made clear on the README.md or on this ticket. Sorry for creating noise.

@trallnag
Copy link

@FranciscoKurpiel, can you share the kubernetes schema url? I cannot seem to find it

@FranciscoKurpiel
Copy link

That's a snippet of my coc-settings.json. It is probably awful in a thousand ways, but it works. Kinda. I mean, who am I to know how to configure neovim?

Note that the URL is for k8s 1.18, but it should work with newer versions after making obvious changes to the url.

{
  "languageserver": {
    "yaml": {
      "filetypes": ["yaml", "yml"],
      "module": "/home/xyko/.config/nvim/plugged/coc-yaml/node_modules/yaml-language-server/out/server/src/server.js"
    }
  },

  "yaml.schemas": {
    "https://raw.githubusercontent.com/instrumenta/kubernetes-json-schema/master/v1.18.0-standalone-strict/all.json": [ "/*.k8s.yaml" ],
    "http://json.schemastore.org/kustomization": [ "kustomization.yaml" ],
    "https://raw.githubusercontent.com/GoogleContainerTools/skaffold/master/docs/content/en/schemas/v2beta8.json": [ "skaffold.yaml" ]
  },

  "yaml.format.enable": true,
  "yaml.validate": true,
  "json.schemaDownload.enable": true,
  "coc.preferences.colorSupport": true
}

@GOodCoffeeLover
Copy link

@JPinkney
Hello!
Sorry, i don't fully understand. This issue mean, that getting error Matches multiple schemas when only one must validate. with kubernetes schemas, which are not hardcoded, is a bug, that need to be solved by someone else, who want make kubernetes support?

Or am i missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants