Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return hover info if description is not available #320

Closed
bhsubra opened this issue Sep 17, 2020 · 2 comments
Closed

Do not return hover info if description is not available #320

bhsubra opened this issue Sep 17, 2020 · 2 comments
Labels

Comments

@bhsubra
Copy link

bhsubra commented Sep 17, 2020

We are getting results back on hover request even if contents is empty. This would require IDEs to add a check to not render it. Range without contents is not useful. Should the language server return null if description is not available?

Message:
{
"jsonrpc": "2.0",
"id": 46,
"result": {
"contents": [
""
],
"range": {
"start": {
"line": 6,
"character": 0
},
"end": {
"line": 6,
"character": 8
}
}
}
}

@ssbarnea
Copy link
Member

ssbarnea commented Jun 3, 2021

IMHO, hover should return "title" when "description" is unavailable. At this moment I did see it returning only the title. I also raised #480 for improving hover info.

@gorkem gorkem added the bug label Mar 24, 2023
@gorkem
Copy link
Collaborator

gorkem commented Mar 24, 2023

Did #500 also fix this one? I am closing, please let me know if it is not fixed for you.

@gorkem gorkem closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants