[Regression] Cloudformation Support #77

17twenty · 2018-07-19T07:48:56Z

Originally closed issue in #20 but it looks like Cloudformation support is no longer present.

This is with the following tags:

...
    "yaml.customTags": [
        "!Ref",
        "!GetAtt",
        "!FindInMap sequence",
        "!FindInMap scalar",
        "!GetAtt",
        "!GetAZs",
        "!Cidr",
        "!ImportValue",
        "!Join sequence",
        "!Select",
        "!Split",
        "!Sub sequence",
        "!Sub scalar",
        "!And",
        "!Equals",
        "!If",
        "!Not",
        "!Or"
    ]

The text was updated successfully, but these errors were encountered:

JPinkney · 2018-07-19T12:24:44Z

What are the errors?

17twenty · 2018-07-19T22:53:37Z

unacceptable node kind for !<!FindInMap> tag; it should be "scalar", not "sequence"

17twenty · 2018-07-19T22:54:11Z

It also triggers follow on errors like missed comma between flow collection entries but that seems to be a knock on effect of the previous

JPinkney · 2018-07-21T19:50:54Z

It looks like instead of checking if the !FindInMap contains either scalar or sequence its looking like it is instead throwing an error when one one is found but not the other.

17twenty · 2018-07-21T22:33:50Z

The sample above is from the AWS codepipeline tutorial here https://s3.amazonaws.com/cloudformation-examples/user-guide/continuous-deployment/wordpress-single-instance.zip

Hope that helps!

dessite · 2018-10-15T13:42:05Z

Any luck with fixing?
I have error

unknown tag <!Ref>

despite having

"yaml.customTags": [
        "!Ref",
        "!GetAtt",
        "!FindInMap sequence",
        "!FindInMap scalar",
        "!GetAtt",
        "!GetAZs",
        "!Cidr",
        "!ImportValue",
        "!Join sequence",
        "!Select",
        "!Split",
        "!Sub sequence",
        "!Sub scalar",
        "!And",
        "!Equals",
        "!If",
        "!Not",
        "!Or"
    ]

str3tch · 2018-10-16T06:28:19Z

I have similar error for !Join:

unacceptable node kind for !<!Join> tag; it should be "scalar", not "sequence"

farmerbean · 2018-10-16T09:11:54Z

I had this issue too. Custom tags setup in user.settings, etc.

Removed cloudformation plugin
Removed rhel yaml plugin

Added in cloudformation plugin
(cloudformation plugin installed rhel yaml dependency)

Problem now (temporarily I assume!) resolved.

wgroenewald · 2018-10-23T07:25:25Z

Still not working for me. This is the contents of my settings.json:
{ "workbench.startupEditor": "newUntitledFile", "git.enableSmartCommit": true, "window.zoomLevel": 0, "files.associations": {}, "yaml.customTags": [ "!Ref", "!GetAtt", "!FindInMap sequence", "!FindInMap scalar", "!GetAtt", "!GetAZs", "!Cidr", "!ImportValue", "!Join sequence", "!Select", "!Split", "!Sub sequence", "!Sub scalar", "!And", "!Equals", "!If", "!Not", "!Or"] }

Still get the error, unknown tag <!Equals>

Anyone have any luck resolving yet?
Tried reinstalling Cloudformation and YAML for RHEL plugin, no luck

deepu105 · 2018-10-25T15:32:34Z

This works for me, but if you are using scalar types with those you will have issues

    "yaml.customTags": [
        "!fn",
        "!And",
        "!If",
        "!Not",
        "!Equals",
        "!Or",
        "!FindInMap sequence",
        "!Base64",
        "!Cidr",
        "!Ref",
        "!Sub",
        "!GetAtt",
        "!GetAZs",
        "!ImportValue",
        "!Select",
        "!Split",
        "!Join sequence"
    ]

sgtoj · 2018-11-15T12:39:27Z

I resolved a similar issue by renaming my template to end with yaml extension. Same file throws errors with yml extension.

dan-petty · 2018-11-21T14:57:53Z

Is there a fix in the works for this? Have to disable validation make the editor usable:
"yaml.validate": false

JPinkney · 2018-11-21T15:10:13Z

Not currently. Would you like to contribute one? I can show you where to get started.

dan-petty · 2018-11-21T20:58:48Z

I'm not familiar with vscode extensions but I can take a look...

JPinkney · 2018-11-21T21:09:05Z

I believe the problem stems from: https://github.com/redhat-developer/yaml-language-server/blob/master/src/languageservice/parser/yamlParser.ts#L256 where we use the custom tags and put them into the yaml-ast-parser.

tanduong · 2018-11-30T10:38:29Z

It appears that after added "!If sequence" to the list of custom tags, I need to restart my editor and it will work.

mandersondesign · 2018-12-18T21:30:12Z

I ended up using this one so far...

"yaml.customTags": [
        "!fn",
        "!And",
        "!If",
        "!Not",
        "!Equals",
        "!Or",
        "!FindInMap sequence",
        "!Base64",
        "!Cidr",
        "!Ref",
        "!Sub",
        "!GetAtt",
        "!GetAZs",
        "!ImportValue",
        "!Select",
        "!Split",
        "!Join sequence",
        "!Select sequence"
    ]

strannik19 · 2019-01-04T10:49:28Z

none of the customTags options work when you mix and max sequence and scalar. it only uses the first one and doesn't allow for the alternative option. so far the only way to go is "yaml.validate": false.

zoellner · 2019-01-11T18:21:01Z

Replacing "!Equals", with "!Equals sequence", in the settings worked for me for this

JPinkney · 2019-03-20T14:48:19Z

Hi everyone! Its been a long time coming but I've finally got custom tags working when you have a tag with multiple different types. That means in the next version you're able to do:

"yaml.customTags": [
        "!myTag1 scalar",
        "!myTag1 mapping",
        "!myTag1 sequence",
    ]

and the document will report no errors if you have something like:

test: !myTag1 hello_world

test2: !myTag1
  hello: world

test3: !myTag1
  - hello: world

Splike · 2019-04-04T10:45:21Z

@JPinkney That's pretty cool! If I just have

"yaml.customTags": [
        "!myTag1"
    ]

I think it would make sense that scalar, mapping and sequence should all be accepted for !myTag1

lorcanoeire · 2019-07-16T10:57:47Z

This is the full set of required configurations (worked for me):

{
    "window.zoomLevel": 0,
    "workbench.colorTheme": "Material Theme Darker",
    "yaml.customTags": [
        "!And scalar",
        "!And mapping",
        "!And sequence",                
        "!If scalar",
        "!If mapping",
        "!If sequence",                
        "!Not scalar",
        "!Not mapping",
        "!Not sequence",                
        "!Equals scalar",
        "!Equals mapping",
        "!Equals sequence",                
        "!Or scalar",
        "!Or mapping",
        "!Or sequence",                
        "!FindInMap scalar",
        "!FindInMap mappping",        
        "!FindInMap sequence",
        "!Base64 scalar",
        "!Base64 mapping",
        "!Base64 sequence",                
        "!Cidr scalar",
        "!Cidr mapping",
        "!Cidr sequence",                
        "!Ref scalar",
        "!Ref mapping",
        "!Ref sequence",                
        "!Sub scalar",
        "!Sub mapping",
        "!Sub sequence",                
        "!GetAtt scalar",
        "!GetAtt mapping",
        "!GetAtt sequence",                
        "!GetAZs scalar",
        "!GetAZs mapping",
        "!GetAZs sequence",                
        "!ImportValue scalar",
        "!ImportValue mapping",
        "!ImportValue sequence",                
        "!Select scalar",
        "!Select mapping",
        "!Select sequence",
        "!Split scalar",
        "!Split mapping",
        "!Split sequence",                
        "!Join scalar",
        "!Join mapping",
        "!Join sequence"                
    ],
    "yaml.format.enable": true,
}

benkehoe · 2019-10-31T13:01:22Z

The CloudFormation extension has added support to do this configuration automatically. aws-cloudformation/cfn-lint-visual-studio-code#65

JPinkney added the bug label Jul 21, 2018

aws-scripting-guy mentioned this issue Sep 7, 2018

YAML syntax error when using AWS intrinsic functions aws-scripting-guy/cform-VSCode#12

Open

JPinkney mentioned this issue Nov 29, 2018

Doesn't like AWS CloudFormation templates #20

Closed

pacohope mentioned this issue Feb 11, 2019

updated settings to reduce YAML parse errors/complaints aws-scripting-guy/cform-VSCode#26

Merged

JPinkney mentioned this issue Mar 6, 2019

Multiple custom tag types #131

Merged

JPinkney added this to the 0.4.0 milestone Mar 12, 2019

JPinkney closed this as completed May 28, 2019

JPinkney mentioned this issue May 28, 2019

Allow custom tags to be any type if not specified #146

Open

kddejong mentioned this issue Nov 1, 2019

Add Missing Custom YAML Tags aws-cloudformation/cfn-lint-visual-studio-code#69

Closed

Slooz mentioned this issue Jan 15, 2022

Allow string operations on nodes with custom tags mikefarah/yq#933

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Regression] Cloudformation Support #77

[Regression] Cloudformation Support #77

17twenty commented Jul 19, 2018

JPinkney commented Jul 19, 2018

17twenty commented Jul 19, 2018

17twenty commented Jul 19, 2018

JPinkney commented Jul 21, 2018

17twenty commented Jul 21, 2018

dessite commented Oct 15, 2018

str3tch commented Oct 16, 2018

farmerbean commented Oct 16, 2018

wgroenewald commented Oct 23, 2018

deepu105 commented Oct 25, 2018

sgtoj commented Nov 15, 2018

dan-petty commented Nov 21, 2018

JPinkney commented Nov 21, 2018

dan-petty commented Nov 21, 2018

JPinkney commented Nov 21, 2018

tanduong commented Nov 30, 2018

mandersondesign commented Dec 18, 2018

strannik19 commented Jan 4, 2019

zoellner commented Jan 11, 2019

JPinkney commented Mar 20, 2019

Splike commented Apr 4, 2019

lorcanoeire commented Jul 16, 2019 •

edited

Loading

benkehoe commented Oct 31, 2019

[Regression] Cloudformation Support #77

[Regression] Cloudformation Support #77

Comments

17twenty commented Jul 19, 2018

JPinkney commented Jul 19, 2018

17twenty commented Jul 19, 2018

17twenty commented Jul 19, 2018

JPinkney commented Jul 21, 2018

17twenty commented Jul 21, 2018

dessite commented Oct 15, 2018

str3tch commented Oct 16, 2018

farmerbean commented Oct 16, 2018

wgroenewald commented Oct 23, 2018

deepu105 commented Oct 25, 2018

sgtoj commented Nov 15, 2018

dan-petty commented Nov 21, 2018

JPinkney commented Nov 21, 2018

dan-petty commented Nov 21, 2018

JPinkney commented Nov 21, 2018

tanduong commented Nov 30, 2018

mandersondesign commented Dec 18, 2018

strannik19 commented Jan 4, 2019

zoellner commented Jan 11, 2019

JPinkney commented Mar 20, 2019

Splike commented Apr 4, 2019

lorcanoeire commented Jul 16, 2019 • edited Loading

benkehoe commented Oct 31, 2019

lorcanoeire commented Jul 16, 2019 •

edited

Loading